From: Larry Finger <Larry.Finger@lwfinger.net>
To: Joe Perches <joe@perches.com>,
Anant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Anoop S <anoop.skumar1507@gmail.com>,
Michael Straube <straube.linux@gmail.com>,
Merwin Trever Ferrao <merwintf@gmail.com>,
Rahul Gottipati <rahul.blr97@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error
Date: Sat, 25 Jul 2020 13:49:19 -0500 [thread overview]
Message-ID: <18de15c4-1737-ae8b-b213-6f44792774be@lwfinger.net> (raw)
In-Reply-To: <d4427fb12f9d4735ec82355bbe99f7b3098fc1a4.camel@perches.com>
On 7/25/20 1:39 PM, Joe Perches wrote:
> On Sat, 2020-07-25 at 12:47 -0500, Larry Finger wrote:
>> On 7/25/20 7:20 AM, Anant Thazhemadam wrote:
>>> Running the checkpatch.pl script on the file for which patch was created, the
>>> following error was found to exist.
>>> ERROR: space required after that ',' (ctx:VxV)
>>>
>>> Fixed the above error which was found on line #721 by inserting a blank
>>> space at the appropriate position.
> []
>>> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> []
>>> @@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
>>> res = _FAIL;
>>> }
>>> } else {
>>> - RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
>>> + RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
>>> res = _FAIL;
>>> }
>>> }
>>
>> In fixing one checkpatch.pl condition, you introduced another - the resulting
>> line is too long. You should fix only one such condition, but you should fix any
>> others that are introduced. You do need to document it.
>
> I think that doesn't matter as it was also too long
> before this change.
>
>> Patch subjects for this driver should be written as "staging: rtl8188eu: .....".
>
> How likely is it that this driver would ever be
> moved to drivers/net/wireless/realtek/rtlwifi?
Very unlikely. It I wanted to undertake that kind of effort, I would switch to
one of the later versions from Realtek that uses nl80211/cfg80211. Despite that,
it is likely that only the USB driver from rtlwifi could be used.
Larry
prev parent reply other threads:[~2020-07-25 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 12:20 [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error Anant Thazhemadam
2020-07-25 17:47 ` Larry Finger
2020-07-25 18:39 ` Joe Perches
2020-07-25 18:49 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18de15c4-1737-ae8b-b213-6f44792774be@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=anant.thazhemadam@gmail.com \
--cc=anoop.skumar1507@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=merwintf@gmail.com \
--cc=rahul.blr97@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).