From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Lokesh Vutla <lokeshvutla@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
tglx@linutronix.de, jason@lakedaemon.net,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
Device Tree Mailing List <devicetree@vger.kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver
Date: Wed, 31 Oct 2018 11:38:00 -0700 [thread overview]
Message-ID: <18df8960-9165-ba50-2c25-9f00d32198e8@oracle.com> (raw)
In-Reply-To: <da27ecc5-db32-cf3a-c194-962c44bc782f@arm.com>
On 10/31/2018 11:21 AM, Marc Zyngier wrote:
> Hi Grygorii,
>
[...]
>
> Well, I'm convinced that we do not want a networking driver to be tied
> to an interrupt architecture, and that the two should be completely
> independent. But that's my own opinion. I can only see two solutions
> moving forward:
>
> 1) You make the IA a real interrupt controller that exposes real
> interrupts (one per event), and write your networking driver
> independently of the underlying interrupt architecture.
>
> 2) you make the IA an integral part of your network driver, not exposing
> anything outside of it, and limiting the interactions with the IR
> *through the standard IRQ API*. You duplicate this knowledge throughout
> the other client drivers.
>
> I believe that (2) would be a massive design mistake as it locks the
> driver to a single of the HW (and potentially a single revision of the
> firmware) while (1) gives you the required level of flexibility by
> hiding the whole event "concept" at a single location.
>
> Yes, (1) makes you rewrite your existing, out of tree drivers. Oh well...
>
My preference is also not tie the network driver with IA. BTW, this is
very standard functionality with other network drivers too. And this
is handled using MSI-X.
So strong NO for 1) from me as well.
regards,
Santosh
next prev parent reply other threads:[~2018-10-31 18:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 15:40 [PATCH v2 00/10] Add support for TISCI irqchip drivers Lokesh Vutla
2018-10-18 15:40 ` [PATCH v2 01/10] firmware: ti_sci: Add support to get TISCI handle using of_phandle Lokesh Vutla
2018-10-18 15:40 ` [PATCH v2 02/10] firmware: ti_sci: Add support for RM core ops Lokesh Vutla
2018-10-18 15:40 ` [PATCH v2 03/10] firmware: ti_sci: Add support for IRQ management Lokesh Vutla
2018-10-18 15:40 ` [PATCH v2 04/10] firmware: ti_sci: Add RM mapping table for am654 Lokesh Vutla
2018-10-18 20:42 ` Rob Herring
2018-10-18 15:40 ` [PATCH v2 05/10] firmware: ti_sci: Add helper apis to manage resources Lokesh Vutla
2018-10-18 15:40 ` [PATCH v2 06/10] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings Lokesh Vutla
2018-10-25 18:45 ` Rob Herring
2018-10-26 6:38 ` Lokesh Vutla
2018-10-18 15:40 ` [PATCH v2 07/10] irqchip: ti-sci-intr: Add support for Interrupt Router driver Lokesh Vutla
2018-10-18 15:40 ` [PATCH v2 08/10] dt-bindings: irqchip: Introduce TISCI Interrupt Aggregator bindings Lokesh Vutla
2018-10-18 15:40 ` [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver Lokesh Vutla
2018-10-19 15:22 ` Marc Zyngier
2018-10-22 14:35 ` Lokesh Vutla
2018-10-23 13:50 ` Marc Zyngier
2018-10-26 6:39 ` Lokesh Vutla
2018-10-26 20:19 ` Lokesh Vutla
2018-10-28 13:31 ` Marc Zyngier
2018-10-29 13:04 ` Lokesh Vutla
2018-11-01 7:55 ` Peter Ujfalusi
2018-11-01 9:00 ` Marc Zyngier
2018-11-01 9:14 ` Peter Ujfalusi
2018-11-05 8:08 ` Lokesh Vutla
2018-11-05 15:36 ` Marc Zyngier
2018-11-05 16:20 ` Lokesh Vutla
2018-11-05 16:44 ` Marc Zyngier
2018-11-05 17:56 ` Lokesh Vutla
2018-10-31 16:39 ` Grygorii Strashko
2018-10-31 18:21 ` Marc Zyngier
2018-10-31 18:38 ` Santosh Shilimkar [this message]
2018-10-31 18:42 ` Marc Zyngier
2018-10-31 18:48 ` Santosh Shilimkar
2018-10-31 20:33 ` Grygorii Strashko
2018-11-01 14:52 ` Marc Zyngier
2018-11-01 15:36 ` Grygorii Strashko
2018-11-01 9:09 ` Peter Ujfalusi
2018-10-22 10:42 ` Peter Ujfalusi
2018-10-22 10:43 ` Peter Ujfalusi
2018-10-18 15:40 ` [PATCH v2 10/10] soc: ti: am6: Enable interrupt controller drivers Lokesh Vutla
2018-10-22 20:39 ` [PATCH v2 00/10] Add support for TISCI irqchip drivers Santosh Shilimkar
2018-10-23 8:17 ` Lokesh Vutla
2018-10-23 8:27 ` Marc Zyngier
2018-10-23 17:34 ` Santosh Shilimkar
2018-10-26 6:39 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18df8960-9165-ba50-2c25-9f00d32198e8@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=marc.zyngier@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).