From: Dmitry Osipenko <digetx@gmail.com>
To: Krishna Yarlagadda <kyarlagadda@nvidia.com>,
linux-i2c@vger.kernel.org, thierry.reding@gmail.com
Cc: jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, ldewangan@nvidia.com,
smohammed@nvidia.com, rgumasta@nvidia.com
Subject: Re: [PATCH 6/7] i2c: tegra: DMA support for t186 and t194
Date: Thu, 23 Jul 2020 16:38:28 +0300 [thread overview]
Message-ID: <18e4e5df-3d8f-3e52-b9b2-ff0558d6196c@gmail.com> (raw)
In-Reply-To: <1595506733-10307-6-git-send-email-kyarlagadda@nvidia.com>
23.07.2020 15:18, Krishna Yarlagadda пишет:
> Enable GPC DMA support for Tegra186 and Tegra194
>
> Signed-off-by: Rajesh Gumasta <rgumasta@nvidia.com>
> Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 25 ++++++++++++++++++++-----
> 1 file changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index 8ab968e..77198fc 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -236,6 +236,7 @@ struct tegra_i2c_hw_feature {
> u32 setup_hold_time_hs_mode;
> bool has_interface_timing_reg;
> bool has_slcg_support;
> + bool has_gpc_dma;
> };
>
> /**
> @@ -432,11 +433,18 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
> dma_addr_t dma_phys;
> int err;
>
> - if (!i2c_dev->hw->has_apb_dma)
> - return 0;
> -
> - if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) {
> - dev_dbg(i2c_dev->dev, "Support for APB DMA not enabled!\n");
> + if (i2c_dev->hw->has_gpc_dma) {
> + if (!IS_ENABLED(CONFIG_TEGRA_GPC_DMA)) {
Single line, please.
> + dev_dbg(i2c_dev->dev, "Support for GPC DMA not enabled!\n");
> + return 0;
> + }
> + } else if (i2c_dev->hw->has_apb_dma) {
> + if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) {
Here too.
> + dev_dbg(i2c_dev->dev, "Support for APB DMA not enabled!\n");
> + return 0;
> + }
> + } else {
> + dev_dbg(i2c_dev->dev, "DMA is not enabled!\n");
Also, please drop all the exclamation marks.
next prev parent reply other threads:[~2020-07-23 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 12:18 [PATCH 1/7] i2c: tegra: remove dead code Krishna Yarlagadda
2020-07-23 12:18 ` [PATCH 2/7] i2c: tegra: Fix setting of controller ID Krishna Yarlagadda
2020-07-23 12:18 ` [PATCH 3/7] i2c: tegra: add flag for register write buffering Krishna Yarlagadda
2020-07-23 13:17 ` Dmitry Osipenko
2020-07-23 12:18 ` [PATCH 4/7] i2c: tegra: add high speed mode support Krishna Yarlagadda
2020-07-23 13:27 ` Dmitry Osipenko
2020-07-25 11:26 ` Michał Mirosław
2020-07-23 12:18 ` [PATCH 5/7] i2c: tegra: enable second level clock gating Krishna Yarlagadda
2020-07-23 14:01 ` Dmitry Osipenko
2020-07-23 12:18 ` [PATCH 6/7] i2c: tegra: DMA support for t186 and t194 Krishna Yarlagadda
2020-07-23 13:16 ` Dmitry Osipenko
2020-07-23 13:38 ` Dmitry Osipenko [this message]
2020-07-23 12:18 ` [PATCH 7/7] i2c: tegra: dump I2C registers on timeout Krishna Yarlagadda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18e4e5df-3d8f-3e52-b9b2-ff0558d6196c@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rgumasta@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).