From: Sarbojit Ganguly <ganguly.s@samsung.com>
To: Will Deacon <will.deacon@arm.com>,
Sarbojit Ganguly <ganguly.s@samsung.com>
Cc: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"Waiman.Long@hp.com" <Waiman.Long@hp.com>,
"peterz@infradead.org" <peterz@infradead.org>,
VIKRAM MUPPARTHI <vikram.m@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
SUNEEL KUMAR SURIMANI <suneel@samsung.com>,
SHARAN ALLUR <sharan.allur@samsung.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: [PATCH v2] arm: Adding support for atomic half word exchange
Date: Mon, 05 Oct 2015 13:10:55 +0000 (GMT) [thread overview]
Message-ID: <1912649938.590071444050653292.JavaMail.weblogic@epmlwas01c> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 2426 bytes --]
Hello Will,
My sincere apologies for the format issue. This was due to the e-mail editor
which reformats the text.
I am reposting the patch, please let me know if it is ok this time.
v1-->v2 : Extended the guard code to cover the byte exchange case as
well following opinion of Will Deacon.
Checkpatch has been run and issues were taken care of.
Since support for half-word atomic exchange was not there and Qspinlock
on ARM requires it, modified __xchg() to add support for that as well.
ARMv6 and lower does not support ldrex{b,h} so, added a guard code
to prevent build breaks.
Signed-off-by: Sarbojit Ganguly <ganguly.s@samsung.com>
---
arch/arm/include/asm/cmpxchg.h | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/include/asm/cmpxchg.h b/arch/arm/include/asm/cmpxchg.h
index 916a274..a53cbeb 100644
--- a/arch/arm/include/asm/cmpxchg.h
+++ b/arch/arm/include/asm/cmpxchg.h
@@ -39,6 +39,7 @@ static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size
switch (size) {
#if __LINUX_ARM_ARCH__ >= 6
+#if !defined(CONFIG_CPU_V6)
case 1:
asm volatile("@ __xchg1\n"
"1: ldrexb %0, [%3]\n"
@@ -49,6 +50,22 @@ static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size
: "r" (x), "r" (ptr)
: "memory", "cc");
break;
+
+ /*
+ * Half-word atomic exchange, required
+ * for Qspinlock support on ARM.
+ */
+ case 2:
+ asm volatile("@ __xchg2\n"
+ "1: ldrexh %0, [%3]\n"
+ " strexh %1, %2, [%3]\n"
+ " teq %1, #0\n"
+ " bne 1b"
+ : "=&r" (ret), "=&r" (tmp)
+ : "r" (x), "r" (ptr)
+ : "memory", "cc");
+ break;
+#endif
case 4:
asm volatile("@ __xchg4\n"
"1: ldrex %0, [%3]\n"
--
1.9.1
------- Original Message -------
Sender : Will Deacon<will.deacon@arm.com>
Date : Oct 05, 2015 18:19 (GMT+05:30)
Title : Re: [PATCH v2] arm: Adding support for atomic half word exchange
On Mon, Oct 05, 2015 at 03:07:57AM +0000, Sarbojit Ganguly wrote:
> This is my second version of the patch which covers the byte exclusive
> case as pointed out by you.
> Please share your opinion on this.
The patch you posted is corrupted (the whitespace looks completely off)
so it can't be applied like this. Please take a look at your email/git
settings.
Will
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2015-10-05 13:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 13:10 Sarbojit Ganguly [this message]
2015-10-05 16:00 ` Re: [PATCH v2] arm: Adding support for atomic half word exchange Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1912649938.590071444050653292.JavaMail.weblogic@epmlwas01c \
--to=ganguly.s@samsung.com \
--cc=Waiman.Long@hp.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=peterz@infradead.org \
--cc=sharan.allur@samsung.com \
--cc=suneel@samsung.com \
--cc=torvalds@linux-foundation.org \
--cc=vikram.m@samsung.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).