From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58774C433F5 for ; Mon, 11 Apr 2022 16:27:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348543AbiDKQ3Y (ORCPT ); Mon, 11 Apr 2022 12:29:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244728AbiDKQ3T (ORCPT ); Mon, 11 Apr 2022 12:29:19 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F372CF2E; Mon, 11 Apr 2022 09:27:04 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id k22so5281454wrd.2; Mon, 11 Apr 2022 09:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ITFeuhIISg+UteX7JWYJlJzAHiy1YXAVNDcS4HitlFk=; b=CAknTVts7FZNNCh/mOgu+gKhOEu2Y/aqwVxaNM0kHSWyY/glJTkWs+t1hBDlOYMwO0 vOsyAg3ZWt9rKSAYirIRS9YT7GKTIfpwgmj5Hix7tNeNxE5B0sr0C7kyaVIDuiswO/of zvBfzsRABDC/kZAqs7mvbcGUVODaUwnvPUpGan18XlyFAk8QPfIcDjfIw8IX5o1PVYVy NslaqRGIMKHic8ecpxpeEOtp04GwzBPfFbNBtcqWbLMjbaasnYYpRIHG15hGH0Za+K+P hXSyvoeoRbwPciFOiPEojsJL+/Ym8Bq5E5fvF47Dy0DuJsUn0kJ6p+VixB6iykcjd18x wKXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ITFeuhIISg+UteX7JWYJlJzAHiy1YXAVNDcS4HitlFk=; b=XxcNZUfgBSi70q+8npK8/PQ7gS18J/OmYe3ze+4cZ3PYpvrlOcafVizCfq39GpsPuY z2UcirEcqSPisfh71l3abE7PCDHSZ9PNbUrv1stgDuPNErOg8B4jdTwlKboO6TeoK23k 2hKI2cJqXAzECuEibo1ydsiK9unQkk3ONgtY7dQB41NIektY0bCQOCjxy/9tffw0UyP6 Qqj1bHXzrhhEPiCQUcbkWORFsIkn3IRTX0BSBm78lv3FLMswvj6azanHDoqz6fXIB30x Zk0IM3CF66wXNpC7Wsd72Q9qWePB3PYAtbTEmYR1rtiyAmhWrHB3RRlaJadT0+UsGOv7 z50Q== X-Gm-Message-State: AOAM532dP1ibiBfxY9my1bKs/w3XY3ayRTd3oGmVzw3M2pcldcxMvLgs fQe02uZ+WNFWVjgpSu38i5zOFhRq722Ufw== X-Google-Smtp-Source: ABdhPJyn/l/yymgrincqx9jqS6snjtWym7mz9/5OBTtPWM1cOAUYev+ht24Ox443KlRM9ef/kyV1Kw== X-Received: by 2002:a5d:64aa:0:b0:206:d0e:14a5 with SMTP id m10-20020a5d64aa000000b002060d0e14a5mr25308152wrp.705.1649694423153; Mon, 11 Apr 2022 09:27:03 -0700 (PDT) Received: from [192.168.1.122] (cpc159313-cmbg20-2-0-cust161.5-4.cable.virginm.net. [82.0.78.162]) by smtp.gmail.com with ESMTPSA id n65-20020a1c2744000000b003862bfb509bsm18065887wmn.46.2022.04.11.09.27.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 09:27:02 -0700 (PDT) Subject: Re: [PATCH V2] sfc: ef10: Fix assigning negative value to unsigned variable To: Haowen Bai , Martin Habets , "David S. Miller" , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1649640757-30041-1-git-send-email-baihaowen@meizu.com> From: Edward Cree Message-ID: <1912936d-14b5-f6af-c927-c46fabc72da5@gmail.com> Date: Mon, 11 Apr 2022 17:27:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <1649640757-30041-1-git-send-email-baihaowen@meizu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2022 02:32, Haowen Bai wrote: > fix warning reported by smatch: > 251 drivers/net/ethernet/sfc/ef10.c:2259 efx_ef10_tx_tso_desc() > warn: assigning (-208) to unsigned variable 'ip_tot_len' > > Signed-off-by: Haowen Bai > --- Acked-by: Edward Cree > V1->V2: to assign "0x10000 - EFX_TSO2_MAX_HDRLEN" is the actual > semantics of the value. > > drivers/net/ethernet/sfc/ef10.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c > index 50d535981a35..c9ee5011803f 100644 > --- a/drivers/net/ethernet/sfc/ef10.c > +++ b/drivers/net/ethernet/sfc/ef10.c > @@ -2256,7 +2256,7 @@ int efx_ef10_tx_tso_desc(struct efx_tx_queue *tx_queue, struct sk_buff *skb, > * guaranteed to satisfy the second as we only attempt TSO if > * inner_network_header <= 208. > */ > - ip_tot_len = -EFX_TSO2_MAX_HDRLEN; > + ip_tot_len = 0x10000 - EFX_TSO2_MAX_HDRLEN; > EFX_WARN_ON_ONCE_PARANOID(mss + EFX_TSO2_MAX_HDRLEN + > (tcp->doff << 2u) > ip_tot_len); > >