linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ubifs: auth: add CONFIG_KEYS dependency
@ 2018-11-02 11:11 Arnd Bergmann
  2018-11-02 12:23 ` Richard Weinberger
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-11-02 11:11 UTC (permalink / raw)
  To: Richard Weinberger, Artem Bityutskiy, Adrian Hunter
  Cc: Arnd Bergmann, Sascha Hauer, Stefan Agner, linux-mtd, linux-kernel

The new authentication support causes a build failure
when CONFIG_KEYS is disabled, so add a dependency.

fs/ubifs/auth.c: In function 'ubifs_init_authentication':
fs/ubifs/auth.c:249:16: error: implicit declaration of function 'request_key'; did you mean 'request_irq'? [-Werror=implicit-function-declaration]
  keyring_key = request_key(&key_type_logon, c->auth_key_name, NULL);

Fixes: d8a22773a12c ("ubifs: Enable authentication support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 fs/ubifs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
index 529856fbccd0..406c88dc039e 100644
--- a/fs/ubifs/Kconfig
+++ b/fs/ubifs/Kconfig
@@ -89,6 +89,7 @@ config UBIFS_FS_SECURITY
 
 config UBIFS_FS_AUTHENTICATION
 	bool "UBIFS authentication support"
+	depends on KEYS
 	select CRYPTO_HMAC
 	help
 	  Enable authentication support for UBIFS. This feature offers protection
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ubifs: auth: add CONFIG_KEYS dependency
  2018-11-02 11:11 [PATCH] ubifs: auth: add CONFIG_KEYS dependency Arnd Bergmann
@ 2018-11-02 12:23 ` Richard Weinberger
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2018-11-02 12:23 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Artem Bityutskiy, Adrian Hunter, Sascha Hauer, Stefan Agner,
	linux-mtd, linux-kernel

Am Freitag, 2. November 2018, 12:11:22 CET schrieb Arnd Bergmann:
> The new authentication support causes a build failure
> when CONFIG_KEYS is disabled, so add a dependency.
> 
> fs/ubifs/auth.c: In function 'ubifs_init_authentication':
> fs/ubifs/auth.c:249:16: error: implicit declaration of function 'request_key'; did you mean 'request_irq'? [-Werror=implicit-function-declaration]
>   keyring_key = request_key(&key_type_logon, c->auth_key_name, NULL);
> 
> Fixes: d8a22773a12c ("ubifs: Enable authentication support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied!

Thanks,
//richard



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-02 12:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-02 11:11 [PATCH] ubifs: auth: add CONFIG_KEYS dependency Arnd Bergmann
2018-11-02 12:23 ` Richard Weinberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).