I checked. __pmd() works. BTW, my sparc32 fix was added in linux-next on August 11th and __pmd() is there, too. This means __pmd() + my fix has survived for almost a month in linux-next. It should be good. -- Best Regards Yan Zi On 7 Sep 2017, at 23:43, Stephen Rothwell wrote: > Hi all, > > On Fri, 8 Sep 2017 12:49:59 +1000 Stephen Rothwell wrote: >> >> OK, so today I have applied this instead (which is the same as dropping >> mm-thp-enable-thp-migration-in-generic-path-fix-fix-fix): >> >> From: Stephen Rothwell >> Date: Fri, 8 Sep 2017 12:40:39 +1000 >> Subject: [PATCH] mm-thp-enable-thp-migration-in-generic-path-fix-fix >> >> Signed-off-by: Stephen Rothwell >> --- >> include/linux/swapops.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/swapops.h b/include/linux/swapops.h >> index b88441d284e2..291c4b534658 100644 >> --- a/include/linux/swapops.h >> +++ b/include/linux/swapops.h >> @@ -291,7 +291,7 @@ static inline swp_entry_t pmd_to_swp_entry(pmd_t pmd) >> >> static inline pmd_t swp_entry_to_pmd(swp_entry_t entry) >> { >> - return (pmd_t){}; >> + return __pmd(0); >> } >> >> static inline int is_pmd_migration_entry(pmd_t pmd) > > That survived my "during the day" builds (including sparc32). Some one > should just check the overnight build results: > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fkisskb.ellerman.id.au%2Flinux-next&data=02%7C01%7Czi.yan%40cs.rutgers.edu%7C2fd0d9ae031f4c49a49208d4f66bcc34%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C636404390233531971&sdata=%2F2RdKh9%2Fl5P8F1sIticPEnTLJaWyt0xR%2BV6YXFBhsRs%3D&reserved=0 > -- > Cheers, > Stephen Rothwell