From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Medad CChien <medadyoung@gmail.com>,
rric@kernel.org, james.morse@arm.com, tony.luck@intel.com,
mchehab@kernel.org, bp@alien8.de, robh+dt@kernel.org,
benjaminfair@google.com, yuenn@google.com, venture@google.com,
KWLIU@nuvoton.com, YSCHU@nuvoton.com, JJLIU0@nuvoton.com,
KFTING@nuvoton.com, avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
Medad CChien <ctcchien@nuvoton.com>
Subject: Re: [PATCH v1 2/3] dt-bindings: edac: npcm-edac.yaml
Date: Sun, 27 Feb 2022 12:02:32 +0100 [thread overview]
Message-ID: <1924a900-20db-93b5-4f9b-37a56467f7e8@canonical.com> (raw)
In-Reply-To: <20220224074729.5206-3-ctcchien@nuvoton.com>
On 24/02/2022 08:47, Medad CChien wrote:
> Add the device tree bindings for the EDAC driver npcm-edac.
>
> Signed-off-by: Medad CChien <ctcchien@nuvoton.com>
> ---
> .../devicetree/bindings/edac/npcm-edac.yaml | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/edac/npcm-edac.yaml
>
> diff --git a/Documentation/devicetree/bindings/edac/npcm-edac.yaml b/Documentation/devicetree/bindings/edac/npcm-edac.yaml
> new file mode 100644
> index 000000000000..228ace1025dc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/edac/npcm-edac.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/edac/npcm-edac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NPCM Memory Controller EDAC
> +
> +maintainers:
> + - Medad CChien <ctcchien@nuvoton.com>
> +
> +description: |
> + EDAC node is defined to describe on-chip error detection and correction for
> + Nuvoton NPCM Memory Controller.
> +
> +properties:
> + compatible:
> + enum:
> + - nuvoton,npcm8xx-edac
> + - nuvoton,npcm7xx-edac
> +
> + reg:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 2
> +
> + "#size-cells":
> + const: 2
Why do you need it? There are no children nodes allowed.
> +
> + interrupts:
> + minItems: 1
> + items:
> + - description: uncorrectable error interrupt
> + - description: correctable error interrupt
> +
> + interrupt-names:
> + minItems: 1
> + items:
> + - const: ue
> + - const: ce
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + ahb {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + mc: memory-controller@f0824000 {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + reg = <0x0 0xf0824000 0x0 0x1000>;
> + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> + compatible = "nuvoton,npcm7xx-edac";
First compatible, then reg, then the rest, please.
> + };
> + };
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-27 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 7:47 [PATCH v1 0/3] edac: npcm: Add driver for Nuvoton NPCM SoCs Medad CChien
2022-02-24 7:47 ` [PATCH v1 1/3] ARM: dts: nuvoton: Add new device node Medad CChien
2022-02-24 7:47 ` [PATCH v1 2/3] dt-bindings: edac: npcm-edac.yaml Medad CChien
2022-02-25 20:05 ` Rob Herring
2022-02-27 11:02 ` Krzysztof Kozlowski [this message]
2022-02-24 7:47 ` [PATCH v1 3/3] EDAC: nuvoton: Add nuvoton NPCM EDAC driver Medad CChien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1924a900-20db-93b5-4f9b-37a56467f7e8@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=JJLIU0@nuvoton.com \
--cc=KFTING@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=YSCHU@nuvoton.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=bp@alien8.de \
--cc=ctcchien@nuvoton.com \
--cc=devicetree@vger.kernel.org \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=medadyoung@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=rric@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=tony.luck@intel.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).