From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDEEC433F4 for ; Thu, 20 Sep 2018 13:24:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10F442152F for ; Thu, 20 Sep 2018 13:24:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LU4tg5vF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10F442152F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732732AbeITTIP (ORCPT ); Thu, 20 Sep 2018 15:08:15 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:55230 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727078AbeITTIP (ORCPT ); Thu, 20 Sep 2018 15:08:15 -0400 Received: from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 410251A9C; Thu, 20 Sep 2018 15:24:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1537449882; bh=L9EnGKzKs1EFJ/zkSFXs69ONJfQlj44SsOWX9/d4EXw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LU4tg5vFcq7k6Gi18KcttJR18XFtB4I9dqH4URgrlIdP0jMG41o6h1F6EsL2Kd36M Mj9E+BxS4lo1ldlmd/7y0O0QHoaituxySHYA32QVYBjCPlCdwhmei57rgvI1OPRHow lrn3cIWjIZCCzCHUp8wq+8t3VSRqAcTF0rSdMIXI= From: Laurent Pinchart To: Luis Oliveira Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Joao.Pinto@synopsys.com, festevam@gmail.com, Luis Oliveira , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Hans Verkuil , Geert Uytterhoeven , Laurent Pinchart , Arnd Bergmann , Jacob Chen , Neil Armstrong , Keiichi Watanabe , Kate Stewart , Philipp Zabel , Todor Tomov , devicetree@vger.kernel.org Subject: Re: [V2, 4/5] Documentation: dt-bindings: Document bindings for DW MIPI CSI-2 Host Date: Thu, 20 Sep 2018 16:24:54 +0300 Message-ID: <1932462.yjy0pN2BsW@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180920111648.27000-5-lolivei@synopsys.com> References: <20180920111648.27000-1-lolivei@synopsys.com> <20180920111648.27000-5-lolivei@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luis, Thank you for the patch. On Thursday, 20 September 2018 14:16:42 EEST Luis Oliveira wrote: > Add bindings for Synopsys DesignWare MIPI CSI-2 host. > > Signed-off-by: Luis Oliveira > --- > Changelog > v2: > - no changes > > .../devicetree/bindings/media/snps,dw-csi-plat.txt | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt > > diff --git a/Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt > b/Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt new file > mode 100644 > index 0000000..028f5eb > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt > @@ -0,0 +1,74 @@ > +Synopsys DesignWare CSI-2 Host controller > + > +Description > +----------- > + > +This HW block is used to receive image coming from an MIPI CSI-2 compatible > +camera. > + > +Required properties: > +- compatible: shall be "snps,dw-csi-plat" > +- reg : physical base address and size of the device memory mapped > + registers; > +- interrupts : CSI-2 Host interrupt > +- snps,output-type : Core output to be used (IPI-> 0 or IDI->1 or BOTH- >2) > These > + values choose which of the Core outputs will be used, it > + can be Image Data Interface or Image Pixel Interface. > +- phys : List of one PHY specifier (as defined in > + Documentation/devicetree/bindings/phy/phy-bindings.txt). > + This PHY is a MIPI DPHY working in RX mode. > +- resets : Reference to a reset controller (optional) > + > +Optional properties(if in IPI mode): > +- snps,ipi-mode : Mode to be used when in IPI(Camera -> 0 or Controller - > > 1) > + This property defines if the controller will use the video > + timings available > + in the video stream or if it will use pre-defined ones. How does one select this ? > +- snps,ipi-color-mode : Bus depth to be used in IPI (48 bits -> 0 or 16 > bits -> 1) > + This property defines the width of the IPI bus. How about using the standard bus-width property in the endpoint of the output port ? > +- snps,ipi-auto-flush : Data auto-flush (1 -> Yes or 0 -> No). This > property defines > + if the data is automatically flushed in each vsync > or if > + this process is done manually This seems like a configuration option, not a hardware property. I don't think it belongs to DT. > +- snps,virtual-channel : Virtual channel where data is present when in IPI > mode. This > + property chooses the virtual channel which IPI will use to > + retrieve the video stream. The virtual channel doesn't belong to DT, it should be queried from the sensor at runtime (and when a sensor can send multiple data streams, that should even be configurable). > +The per-board settings: > + - port sub-node describing a single endpoint connected to the camera as > + described in video-interfaces.txt[1]. You need to explicitly list all the ports for this device, with their number and function. > +Example: > + > + csi2_1: csi2@3000 { > + compatible = "snps,dw-csi-plat"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = < 0x03000 0x7FF>; > + interrupts = <2>; > + output-type = <2>; > + resets = <&dw_rst 1>; > + phys = <&mipi_dphy_rx1 0>; > + phy-names = "csi2-dphy"; > + > + /* IPI optional Configurations */ > + snps,ipi-mode = <0>; > + snps,ipi-color-mode = <0>; > + snps,ipi-auto-flush = <1>; > + snps,virtual-channel = <0>; > + > + /* CSI-2 per-board settings */ > + port@1 { > + reg = <1>; > + csi1_ep1: endpoint { > + remote-endpoint = <&camera_1>; > + data-lanes = <1 2>; > + }; > + }; > + port@2 { > + csi1_ep2: endpoint { > + remote-endpoint = <&vif1_ep>; > + }; > + }; > + }; > + > + Extra blank lines. -- Regards, Laurent Pinchart