From: yannick Fertre <yannick.fertre@foss.st.com>
To: Raphael GALLAIS-POU - foss <raphael.gallais-pou@foss.st.com>,
"Philippe CORNU - foss" <philippe.cornu@foss.st.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE - foss <alexandre.torgue@foss.st.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Raphael GALLAIS-POU <raphael.gallais-pou@st.com>
Subject: Re: [PATCH] drm/stm: ltdc: add layer alpha support
Date: Tue, 7 Sep 2021 08:55:14 +0200 [thread overview]
Message-ID: <19331273-3464-869e-8e62-a0c3e096ed70@foss.st.com> (raw)
In-Reply-To: <20210903085740.23108-1-raphael.gallais-pou@foss.st.com>
Hi Raphael,
thanks for the patch.
Acked-by: Yannick Fertre <yannick.fertre@foss.st.com>
Reviewed-by: Yannick Fertre <yannick.fertre@foss.st.com>
On 9/3/21 10:58 AM, Raphael GALLAIS-POU - foss wrote:
> Android Hardware Composer supports alpha values applied to layers.
> Enabling non-opaque layers for the STM CRTC could help offload GPU
> resources for screen composition.
>
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 195de30eb90c..e0fef8bacfa8 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -845,7 +845,7 @@ static void ltdc_plane_atomic_update(struct drm_plane *plane,
> LXCFBLR_CFBLL | LXCFBLR_CFBP, val);
>
> /* Specifies the constant alpha value */
> - val = CONSTA_MAX;
> + val = newstate->alpha >> 8;
> reg_update_bits(ldev->regs, LTDC_L1CACR + lofs, LXCACR_CONSTA, val);
>
> /* Specifies the blending factors */
> @@ -997,6 +997,8 @@ static struct drm_plane *ltdc_plane_create(struct drm_device *ddev,
>
> drm_plane_helper_add(plane, <dc_plane_helper_funcs);
>
> + drm_plane_create_alpha_property(plane);
> +
> DRM_DEBUG_DRIVER("plane:%d created\n", plane->base.id);
>
> return plane;
>
next prev parent reply other threads:[~2021-09-07 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 8:58 [PATCH] drm/stm: ltdc: add layer alpha support Raphael GALLAIS-POU - foss
2021-09-07 6:55 ` yannick Fertre [this message]
2021-09-07 15:12 Raphael Gallais-Pou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19331273-3464-869e-8e62-a0c3e096ed70@foss.st.com \
--to=yannick.fertre@foss.st.com \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@foss.st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=philippe.cornu@foss.st.com \
--cc=raphael.gallais-pou@foss.st.com \
--cc=raphael.gallais-pou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).