[PATCH] tpm_tis_spi: use new `delay` structure for SPI transfer delays

[PATCH] tpm_tis_spi: use new `delay` structure for SPI transfer delays

[Alexandru Ardelean]

In a recent change to the SPI subsystem [1], a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current `delay_secs`
with `delay` for this driver.

The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).

[1] commit bebcfd272df6485 ("spi: introduce `delay` field for
`spi_transfer` + spi_transfer_delay_exec()")

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
 drivers/char/tpm/tpm_tis_spi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
index 19513e622053..1990e79afaed 100644
--- a/drivers/char/tpm/tpm_tis_spi.c
+++ b/drivers/char/tpm/tpm_tis_spi.c
@@ -105,7 +105,8 @@ static int tpm_tis_spi_transfer(struct tpm_tis_data *data, u32 addr, u16 len,
 
 		spi_xfer.cs_change = 0;
 		spi_xfer.len = transfer_len;
-		spi_xfer.delay_usecs = 5;
+		spi_xfer.delay.value = 5;
+		spi_xfer.delay.unit = SPI_DELAY_UNIT_USECS;
 
 		if (in) {
 			spi_xfer.tx_buf = NULL;
-- 
2.20.1

Re: [PATCH] tpm_tis_spi: use new `delay` structure for SPI transfer delays

[Jarkko Sakkinen]

On Wed, Dec 04, 2019 at 10:00:49AM +0200, Alexandru Ardelean wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current `delay_secs`
> with `delay` for this driver.

Please, write 'delay_usecs' instead of `delay_usecs`.

/Jarkko

[PATCH V2] tpm_tis_spi: use new `delay` structure for SPI transfer delays

[Alexandru Ardelean]

In a recent change to the SPI subsystem [1], a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current `delay_usecs`
with `delay` for this driver.

The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).

[1] commit bebcfd272df6485 ("spi: introduce `delay` field for
`spi_transfer` + spi_transfer_delay_exec()")

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---

Changelog v1 -> v2:
* fixed typo `delay_secs` -> `delay_usecs`

 drivers/char/tpm/tpm_tis_spi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
index 19513e622053..1990e79afaed 100644
--- a/drivers/char/tpm/tpm_tis_spi.c
+++ b/drivers/char/tpm/tpm_tis_spi.c
@@ -105,7 +105,8 @@ static int tpm_tis_spi_transfer(struct tpm_tis_data *data, u32 addr, u16 len,
 
 		spi_xfer.cs_change = 0;
 		spi_xfer.len = transfer_len;
-		spi_xfer.delay_usecs = 5;
+		spi_xfer.delay.value = 5;
+		spi_xfer.delay.unit = SPI_DELAY_UNIT_USECS;
 
 		if (in) {
 			spi_xfer.tx_buf = NULL;
-- 
2.20.1

Re: [PATCH V2] tpm_tis_spi: use new `delay` structure for SPI transfer delays

[Jarkko Sakkinen]

On Tue, Dec 10, 2019 at 08:56:19AM +0200, Alexandru Ardelean wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current `delay_usecs`
> with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6485 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")

Not sure why you use ` and not '?

/Jarkko

Re: [PATCH V2] tpm_tis_spi: use new `delay` structure for SPI transfer delays

[Ardelean, Alexandru]

On Wed, 2019-12-11 at 19:37 +0200, Jarkko Sakkinen wrote:
> [External]
> 
> On Tue, Dec 10, 2019 at 08:56:19AM +0200, Alexandru Ardelean wrote:
> > In a recent change to the SPI subsystem [1], a new `delay` struct was
> > added
> > to replace the `delay_usecs`. This change replaces the current
> > `delay_usecs`
> > with `delay` for this driver.
> > 
> > The `spi_transfer_delay_exec()` function [in the SPI framework] makes
> > sure
> > that both `delay_usecs` & `delay` are used (in this order to preserve
> > backwards compatibility).
> > 
> > [1] commit bebcfd272df6485 ("spi: introduce `delay` field for
> > `spi_transfer` + spi_transfer_delay_exec()")
> 
> Not sure why you use ` and not '?

That's a habit from Github's Markdown.
We keep our kernel repo on Github and Markdown formats `text` into a
certain form.
When I open a PR, the PR text is formatted to highlight certain elements
[that I want highlighted].
I did not get any comments on it so far.

I can change it if you want.

As a secondary note: Markdown seems to be used on Gitlab and Bitbucket

Thanks
Alex

> 
> /Jarkko

Re: [PATCH V2] tpm_tis_spi: use new `delay` structure for SPI transfer delays

[Jarkko Sakkinen]

On Thu, 2019-12-12 at 07:21 +0000, Ardelean, Alexandru wrote:
> That's a habit from Github's Markdown.
> We keep our kernel repo on Github and Markdown formats `text` into a
> certain form.

Ah.

> When I open a PR, the PR text is formatted to highlight certain elements
> [that I want highlighted].
> I did not get any comments on it so far.
> 
> I can change it if you want.
> 
> As a secondary note: Markdown seems to be used on Gitlab and Bitbucket

Please change it.

/Jarkko

[PATCH V3] tpm_tis_spi: use new 'delay' structure for SPI transfer delays

[Alexandru Ardelean]

In a recent change to the SPI subsystem [1], a new 'delay' struct was added
to replace the 'delay_usecs'. This change replaces the current
'delay_usecs' with 'delay' for this driver.

The 'spi_transfer_delay_exec()' function [in the SPI framework] makes sure
that both 'delay_usecs' & 'delay' are used (in this order to preserve
backwards compatibility).

[1] commit bebcfd272df6485 ("spi: introduce `delay` field for
`spi_transfer` + spi_transfer_delay_exec()")

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---

Changelog v2 -> v3:
* replaced symbol ` with ' ; did not change it for title of
  commit bebcfd272df6485 , since that one has been commited with
  symbol ` in the commit title

 drivers/char/tpm/tpm_tis_spi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
index d1754fd6c573..d96755935529 100644
--- a/drivers/char/tpm/tpm_tis_spi.c
+++ b/drivers/char/tpm/tpm_tis_spi.c
@@ -110,7 +110,8 @@ int tpm_tis_spi_transfer(struct tpm_tis_data *data, u32 addr, u16 len,
 
 		spi_xfer.cs_change = 0;
 		spi_xfer.len = transfer_len;
-		spi_xfer.delay_usecs = 5;
+		spi_xfer.delay.value = 5;
+		spi_xfer.delay.unit = SPI_DELAY_UNIT_USECS;
 
 		if (in) {
 			spi_xfer.tx_buf = NULL;
-- 
2.20.1

Re: [PATCH V3] tpm_tis_spi: use new 'delay' structure for SPI transfer delays

[Jarkko Sakkinen]

On Tue, 2019-12-17 at 11:16 +0200, Alexandru Ardelean wrote:
> In a recent change to the SPI subsystem [1], a new 'delay' struct was added
> to replace the 'delay_usecs'. This change replaces the current
> 'delay_usecs' with 'delay' for this driver.
> 
> The 'spi_transfer_delay_exec()' function [in the SPI framework] makes sure
> that both 'delay_usecs' & 'delay' are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6485 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

Re: [PATCH V3] tpm_tis_spi: use new 'delay' structure for SPI transfer delays

[Ardelean, Alexandru]

On Tue, 2019-12-17 at 14:04 +0200, Jarkko Sakkinen wrote:
> [External]
> 
> On Tue, 2019-12-17 at 11:16 +0200, Alexandru Ardelean wrote:
> > In a recent change to the SPI subsystem [1], a new 'delay' struct was added
> > to replace the 'delay_usecs'. This change replaces the current
> > 'delay_usecs' with 'delay' for this driver.
> > 
> > The 'spi_transfer_delay_exec()' function [in the SPI framework] makes sure
> > that both 'delay_usecs' & 'delay' are used (in this order to preserve
> > backwards compatibility).
> > 
> > [1] commit bebcfd272df6485 ("spi: introduce `delay` field for
> > `spi_transfer` + spi_transfer_delay_exec()")
> > 
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 

ping on this patch

> /Jarkko
> 

Re: [PATCH V3] tpm_tis_spi: use new 'delay' structure for SPI transfer delays

[Jarkko Sakkinen]

On Wed, Feb 26, 2020 at 07:51:06AM +0000, Ardelean, Alexandru wrote:
> On Tue, 2019-12-17 at 14:04 +0200, Jarkko Sakkinen wrote:
> > [External]
> > 
> > On Tue, 2019-12-17 at 11:16 +0200, Alexandru Ardelean wrote:
> > > In a recent change to the SPI subsystem [1], a new 'delay' struct was added
> > > to replace the 'delay_usecs'. This change replaces the current
> > > 'delay_usecs' with 'delay' for this driver.
> > > 
> > > The 'spi_transfer_delay_exec()' function [in the SPI framework] makes sure
> > > that both 'delay_usecs' & 'delay' are used (in this order to preserve
> > > backwards compatibility).
> > > 
> > > [1] commit bebcfd272df6485 ("spi: introduce `delay` field for
> > > `spi_transfer` + spi_transfer_delay_exec()")
> > > 
> > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> > 
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > 
> 
> ping on this patch

My bad. Sorry. It is now applied.

/Jarkko

Re: [PATCH V3] tpm_tis_spi: use new 'delay' structure for SPI transfer delays

[Ardelean, Alexandru]

On Wed, 2020-02-26 at 17:10 +0200, Jarkko Sakkinen wrote:
> [External]
> 
> On Wed, Feb 26, 2020 at 07:51:06AM +0000, Ardelean, Alexandru wrote:
> > On Tue, 2019-12-17 at 14:04 +0200, Jarkko Sakkinen wrote:
> > > [External]
> > > 
> > > On Tue, 2019-12-17 at 11:16 +0200, Alexandru Ardelean wrote:
> > > > In a recent change to the SPI subsystem [1], a new 'delay' struct was
> > > > added
> > > > to replace the 'delay_usecs'. This change replaces the current
> > > > 'delay_usecs' with 'delay' for this driver.
> > > > 
> > > > The 'spi_transfer_delay_exec()' function [in the SPI framework] makes
> > > > sure
> > > > that both 'delay_usecs' & 'delay' are used (in this order to preserve
> > > > backwards compatibility).
> > > > 
> > > > [1] commit bebcfd272df6485 ("spi: introduce `delay` field for
> > > > `spi_transfer` + spi_transfer_delay_exec()")
> > > > 
> > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> > > 
> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > 
> > 
> > ping on this patch
> 
> My bad. Sorry. It is now applied.

No worries.
Thanks :)

> 
> /Jarkko