From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751547AbcFIMmc (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Jun 2016 08:42:32 -0400
Received: from mout.kundenserver.de ([212.227.126.131]:65211 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750810AbcFIMma (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Jun 2016 08:42:30 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>, Bjorn Helgaas <bhelgaas@google.com>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rockchip@lists.infradead.org, Heiko Stuebner <heiko@sntech.de>,
        Doug Anderson <dianders@chromium.org>,
        Wenrui Li <wenrui.li@rock-chips.com>, Rob Herring <robh+dt@kernel.org>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PCI: Rockchip: Add Rockchip PCIe controller support
Date: Wed, 08 Jun 2016 22:06:21 +0200
Message-ID: <19495840.MdNPOj1Q7K@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <5757E397.40401@arm.com>
References: <1465373154-882-1-git-send-email-shawn.lin@rock-chips.com> <5757E397.40401@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:97o5G8O0lqtlSa4MOVSwN1oXdQCIQoHpJ/3vjbOIjtyTRxcfIYO
 g/u2rgrsco5xMPe63RY2FwEIRgPEkD2yR9weo6Lcq5BJ4XkC+C/HmVsm9CxPeOErNxNMfll
 RwyfluessRhDiIDrqH1KcDx9uncO5kwKxNBBw9dS89BW8yFJtj/5133RhuASflIAptlChBv
 sFc2w6xp7G9qMVjdcZJAA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:DB6fRhjeytk=:QzSzYjePh1MuqWPKM4uXSl
 6S+XZbKLhW87chwqLQKXAu/T9KLFvyOKnT8ufnXyZZyHS35hoAGPdBqaH+WaGAiQWF5fIqoIw
 pK22Zm+IWnXE6CX25dylzvS1Ug1pkSaUSCLv4XsusLtY1ZGgfIZzySO1vEV6nTe36i+BNylcb
 KXzrq6BomLTNwvDAJIQma9QASDhz3EQ+HEgaYH3nkJyEm5Bxh+eW7WjHD2XORofF70vzBTSa1
 ePlU52pG7mwFuc3BkAs27PROIoF08NoD9EVLyFnfRVJicQJ7WFXAH10ayc7Ias81ESHC35zoX
 ivPCpOprshumkTkSD8rATI7c2jNqz8NYF3A9+K8rBfHT8w4T1yQNUUNFUs2ibopIBu0UOwNgC
 pHXMAnPzpXl4V61NsT9mfIrITO721AmnIQTiXF0I0nGXarJSaDdXGHXs0oowyNba06LZCFFA5
 n1G1aHYJlz4c9/tv9yId4HyLEy/v8sGz3qVBgQgWeT3BAeI/Cmt65kjyKfYkfttUUlfc3zGUl
 VkU1qpB/XjOrAO4mGzRx0KwsdfYM0FRHnCLJyC2GuY6KNB+6ctRzIjHzErLzEwEIHZIEmtVoE
 OpYniNRTpUDz2rN23Tebuf2s8yChtCoLkSkEgDSN0BjBoXhSMOjTWjy71KWOQNiWnjitknMFh
 AgLchpmYo2MgIj51kb5BS1Fq071KqbSO/404Fk2MwVelHz4avG2s221uIikGzAMZQCuyIG0VR
 Iw91ajOl0Furus3b
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, June 8, 2016 10:21:27 AM CEST Marc Zyngier wrote:
> > +     rockchip_pcie_enable_interrupts(port);
> > +     if (!IS_ENABLED(CONFIG_PCI_MSI)) {
> > +             err = rockchip_pcie_init_irq_domain(port);
> > +             if (err < 0)
> > +                     goto err_vpcie;
> 
> Why are you excluding wired interrupts if you have PCI_MSI configured?
> MSI allocation can fail, and wired interrupts become handy....

Also, a lot of drivers don't do MSI and rely on legacy interrupts.

	Arnd