From: David Howells <dhowells@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: dhowells@redhat.com, Wolfram Sang <wsa@the-dreams.de>,
wolfram@the-dreams.de, khali@linux-fr.org,
linux-i2c@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS
Date: Thu, 06 Mar 2014 13:13:55 +0000 [thread overview]
Message-ID: <19542.1394111635@warthog.procyon.org.uk> (raw)
In-Reply-To: <11165.1393507178@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> > Can we have something like this for 'flags'?
>
> There's a __print_flags() which should work. One thing I'm concerned about
> there is how do we handle more flags being added - does that count as an ABI
> break if the printed format changes?
>
> SMBus flags are basically the same as I2C flags, right?
Hmmm... __print_flags() seems to append a string if a flag is set, and doesn't
if it isn't set. It places a separator between each string. I would prefer
something that emits a single char per flag or a dash if it isn't present.
Are you okay with that?
David
next prev parent reply other threads:[~2014-03-06 13:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 21:49 [PATCH 1/2] i2c: Add message transfer tracepoints for I2C David Howells
2014-01-09 21:50 ` [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS David Howells
2014-02-18 20:54 ` Wolfram Sang
2014-02-27 13:19 ` David Howells
2014-02-28 21:21 ` Wolfram Sang
2014-03-01 7:48 ` David Howells
2014-03-06 13:13 ` David Howells [this message]
2014-03-06 13:17 ` Wolfram Sang
2014-03-06 13:38 ` David Howells
2014-01-22 19:09 ` [PATCH 1/2] i2c: Add message transfer tracepoints for I2C Wolfram Sang
2014-02-18 20:33 ` Wolfram Sang
2014-02-27 13:07 ` David Howells
2014-02-28 21:17 ` Wolfram Sang
2014-03-01 7:54 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19542.1394111635@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=wolfram@the-dreams.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).