From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753619AbcLGTBg (ORCPT ); Wed, 7 Dec 2016 14:01:36 -0500 Received: from gloria.sntech.de ([95.129.55.99]:40545 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753105AbcLGTBe (ORCPT ); Wed, 7 Dec 2016 14:01:34 -0500 From: Heiko Stuebner To: Brian Norris Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Caesar Wang , Doug Anderson , devicetree@vger.kernel.org, Rob Herring , Stephen Barber , linux-arm-kernel@lists.infradead.org, Chris Zhong Subject: Re: [PATCH 4/9] arm64: dts: rockchip: support dwc3 USB for rk3399 Date: Wed, 07 Dec 2016 20:01:23 +0100 Message-ID: <1972184.o3UeJg0tK9@phil> User-Agent: KMail/5.2.3 (Linux/4.7.0-1-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <20161207175208.GB87970@google.com> References: <1480645653-36943-1-git-send-email-briannorris@chromium.org> <2947180.ggfADt6cbn@phil> <20161207175208.GB87970@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 7. Dezember 2016, 09:52:08 CET schrieb Brian Norris: > Hi, > > On Wed, Dec 07, 2016 at 06:09:16PM +0100, Heiko Stuebner wrote: > > Am Donnerstag, 1. Dezember 2016, 18:27:28 CET schrieb Brian Norris: > > > Add the dwc3 usb needed node information for rk3399. > > > > > > Signed-off-by: Brian Norris > > > --- > > > Somewhat rewritten from Caesar's reposting (v2) of my patch. > > > > > > Changes: > > > * Include USB2 PHY (which is now in -next) > > > * Don't include USB3 PHY, as extcon support is not ready yet > > > * Drop non-upstream properties > > > * Fixup whitespace a bit > > > > > > --- > > > > > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 60 > > > > > > ++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index > > > 4ca8f9a7601c..1e97fb8c6415 > > > 100644 > > > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > > @@ -316,6 +316,66 @@ > > > > > > }; > > > > > > }; > > > > > > + usbdrd3_0: usb@fe800000 { > > > > insert location above usb@fe380000 is sorted wrong > > So, *how* do you think things are sorted here? Alphabetical by label? Or > by node name? Or by unit address? I guess I'm seeing you meant unit > address. correct. Per unit-address first, nodes without address alphabetical by node- name (above nodes with addresses), never by label. > But pcie@f8000000 is also out of order then. I guess maybe > that's the only one then. Yep, pcie is misplaced as sadly sometimes I miss those errors as well. Heiko > > > + compatible = "rockchip,rk3399-dwc3"; > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + ranges; > > > + clocks = <&cru SCLK_USB3OTG0_REF>, <&cru SCLK_USB3OTG0_SUSPEND>, > > > + <&cru ACLK_USB3OTG0>, <&cru ACLK_USB3_RKSOC_AXI_PERF>, > > > + <&cru ACLK_USB3>, <&cru ACLK_USB3_GRF>; > > > + clock-names = "clk_usb3otg0_ref", "clk_usb3otg0_suspend", > > > + "aclk_usb3otg0", "aclk_usb3_rksoc_axi_perf", > > > + "aclk_usb3", "aclk_usb3_grf"; > > > > clock-names do not match binding. The dwc3-of-simple does not care, as it > > just enables all of them it seems, but binding doc states the clock names > > as> > > - clock-names: Should contain the following: > > "ref_clk" Controller reference clk, have to be 24 MHz > > "suspend_clk" Controller suspend clk, have to be 24 MHz or 32 KHz > > "bus_clk" Master/Core clock, have to be >= 62.5 MHz for SS > > > > operation and >= 30MHz for HS operation > > > > "grf_clk" Controller grf clk > > Ah, sorry. I'll try to go with the rockchip,dwc3.txt names better. > > There are a few extra clocks here now, but I think those might only be > for USB3 support, which isn't really working yet. I'll either document > them or drop them. > > > > + resets = <&cru SRST_A_USB3_OTG0>; > > > + reset-names = "usb3-otg"; > > > > you could update the binding documentation to list this one. > > Similar story; this is only used for some of the hacky stuff Rockchip is > doing for USB3/TypeC stuff out of tree. I'll either document it or drop > it (as I'm not actually using it yet). > > Thanks, > Brian > > > Heiko > > > > > + status = "disabled"; > > > + > > > + usbdrd_dwc3_0: dwc3 { > > > + compatible = "snps,dwc3"; > > > + reg = <0x0 0xfe800000 0x0 0x100000>; > > > + interrupts = ; > > > + dr_mode = "otg"; > > > + phys = <&u2phy0_otg>; > > > + phy-names = "usb2-phy"; > > > + snps,dis_enblslpm_quirk; > > > + snps,dis-u2-freeclk-exists-quirk; > > > + snps,dis_u2_susphy_quirk; > > > + snps,dis-del-phy-power-chg-quirk; > > > + status = "disabled"; > > > + }; > > > + }; > > [...]