From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751840AbdHAK2n (ORCPT ); Tue, 1 Aug 2017 06:28:43 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:45515 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbdHAK2m (ORCPT ); Tue, 1 Aug 2017 06:28:42 -0400 From: Laurent Pinchart To: Linus Walleij Cc: Lee Jones , Daniel Thompson , Jingoo Han , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2 v2] backlight: gpio: delete pdata inversion Date: Tue, 01 Aug 2017 13:28:53 +0300 Message-ID: <1973469.qbbesreyky@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.34-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: <20170530114822.24308-2-linus.walleij@linaro.org> References: <20170530114822.24308-1-linus.walleij@linaro.org> <20170530114822.24308-2-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, Thank you for the patch. On Tuesday 30 May 2017 13:48:22 Linus Walleij wrote: > The option to invert the output of the GPIO (active low) is > not used by the only platform still using platform data to > set up a GPIO backlight (one SH board). Delete the option > as we do not expect to expand the use of board files for > this driver, and GPIO descriptors intrinsically keep track > of any signal inversion. > > Acked-by: Daniel Thompson > Signed-off-by: Linus Walleij Reviewed-by: Laurent Pinchart > --- > ChangeLog v1->v2: > - Rebase on the v2 of patch [1/2] > --- > drivers/video/backlight/gpio_backlight.c | 15 ++------------- > include/linux/platform_data/gpio_backlight.h | 1 - > 2 files changed, 2 insertions(+), 14 deletions(-) > > diff --git a/drivers/video/backlight/gpio_backlight.c > b/drivers/video/backlight/gpio_backlight.c index 5ffaff1e4142..e470da95d806 > 100644 > --- a/drivers/video/backlight/gpio_backlight.c > +++ b/drivers/video/backlight/gpio_backlight.c > @@ -25,7 +25,6 @@ struct gpio_backlight { > struct device *fbdev; > > struct gpio_desc *gpiod; > - int active; > int def_value; > }; > > @@ -39,8 +38,7 @@ static int gpio_backlight_update_status(struct > backlight_device *bl) bl->props.state & (BL_CORE_SUSPENDED | > BL_CORE_FBBLANK)) > brightness = 0; > > - gpiod_set_value_cansleep(gbl->gpiod, > - brightness ? gbl->active : !gbl->active); > + gpiod_set_value_cansleep(gbl->gpiod, brightness); > > return 0; > } > @@ -69,8 +67,6 @@ static int gpio_backlight_probe_dt(struct platform_device > *pdev, > > gbl->def_value = of_property_read_bool(np, "default-on"); > flags = gbl->def_value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW; > - /* GPIO descriptors keep track of inversion */ > - gbl->active = 1; > > gbl->gpiod = devm_gpiod_get(dev, NULL, flags); > if (IS_ERR(gbl->gpiod)) { > @@ -121,15 +117,8 @@ static int gpio_backlight_probe(struct platform_device > *pdev) unsigned long flags = GPIOF_DIR_OUT; > > gbl->fbdev = pdata->fbdev; > - gbl->active = pdata->active_low ? 0 : 1; > gbl->def_value = pdata->def_value; > - > - if (gbl->active) > - flags |= gbl->def_value ? > - GPIOF_INIT_HIGH : GPIOF_INIT_LOW; > - else > - flags |= gbl->def_value ? > - GPIOF_INIT_LOW : GPIOF_INIT_HIGH; > + flags |= gbl->def_value ? GPIOF_INIT_HIGH : GPIOF_INIT_LOW; > > ret = devm_gpio_request_one(gbl->dev, pdata->gpio, flags, > pdata ? pdata->name : "backlight"); > diff --git a/include/linux/platform_data/gpio_backlight.h > b/include/linux/platform_data/gpio_backlight.h index > 5ae0d9c80d4d..683d90453c41 100644 > --- a/include/linux/platform_data/gpio_backlight.h > +++ b/include/linux/platform_data/gpio_backlight.h > @@ -14,7 +14,6 @@ struct gpio_backlight_platform_data { > struct device *fbdev; > int gpio; > int def_value; > - bool active_low; > const char *name; > }; -- Regards, Laurent Pinchart