From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752070AbdFTOR3 (ORCPT ); Tue, 20 Jun 2017 10:17:29 -0400 Received: from gloria.sntech.de ([95.129.55.99]:56184 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbdFTOR2 (ORCPT ); Tue, 20 Jun 2017 10:17:28 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: dri-devel@lists.freedesktop.org Cc: Jose Abreu , Mark Yao , Laurent Pinchart , linux-kernel@vger.kernel.org, Carlos Palminha , Kieran Bingham Subject: Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY Date: Tue, 20 Jun 2017 16:17:20 +0200 Message-ID: <1976773.MN42cL7gn5@diego> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <6071fd12-2cda-cd1f-2607-9a498f588040@synopsys.com> References: <6071fd12-2cda-cd1f-2607-9a498f588040@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jose, Am Freitag, 9. Juni 2017, 13:53:12 CEST schrieb Jose Abreu: > On 09-06-2017 12:04, Jose Abreu wrote: > > Currently HDMI 2.0 PHYs do not have a default configuration function. > > > > As these PHYs have the same register layout as the 3D PHYs we can > > safely use the default configuration function. > > I may have been a little to fast arriving at this conclusion. I > mean most of the registers match but in the configuration > function there are registers that do not match. Did you actually > test this configuration function with an HDMI 2.0 phy? And did > you test with different video modes? From my experience the phy > may be wrongly configured and sometimes work anyway. > > Do please retest with as many video modes as you can and give me > your phy ID (read from controller config reg HDMI_CONFIG2_ID). while I'm not Mark and haven't got a working display chain in my test setup yet, I can at least provide the requested phy-id. The value in CONFIG2_ID is 0xf3 on the rk3399 (same on rk3368), which of course resolves to DW_HDMI_PHY_DWC_HDMI20_TX_PHY. Heiko > > If, for some reason, > > > > the PHY is custom this change will not make any impact because > > in configuration function we prefer the pdata provided configuration > > function over the internal one. > > > > This patch is based on today's drm-misc-next branch. > > > > Signed-off-by: Jose Abreu > > Cc: Kieran Bingham > > Cc: Laurent Pinchart > > Cc: Archit Taneja > > Cc: Andrzej Hajda > > Cc: Mark Yao > > Cc: Carlos Palminha > > --- > > > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index ead1124..10c8d8c 100644 > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > @@ -2170,6 +2170,7 @@ static irqreturn_t dw_hdmi_irq(int irq, void > > *dev_id) > > > > .name = "DWC HDMI 2.0 TX PHY", > > .gen = 2, > > .has_svsret = true, > > > > + .configure = hdmi_phy_configure_dwc_hdmi_3d_tx, > > > > }, { > > > > .type = DW_HDMI_PHY_VENDOR_PHY, > > .name = "Vendor PHY", > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel