From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: <torvalds@linux-foundation.org>
Cc: <trond.myklebust@primarydata.com>, <Anna.Schumaker@netapp.com>,
<linux-nfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Please pull NFS client changes for Linux 4.7
Date: Fri, 27 May 2016 17:17:29 -0700 (PDT) [thread overview]
Message-ID: <19769bfc-efc7-495f-9574-f771236a9765@default> (raw)
----- torvalds@linux-foundation.org wrote:
> On Fri, May 27, 2016 at 10:14 AM, Boris Ostrovsky
> <boris.ostrovsky@oracle.com> wrote:
> >
> > This breaks on older compilers:
> >
> > CC fs/nfs/nfs4state.o
> > /home/build/linux-linus/fs/nfs/nfs4state.c:69: error: unknown field
> > ‘data’ specified in initializer
>
> Does the attached patch fix it for you?
>
> I don't have easy access to the old compiler, but I _think_ the
> trivial patch of just adding braces around the data initializer
> should
> make old gcc's happy
It does fix it.
This is not the first time we've hit this and people have always been changing code to initialize fields in execution path (and I didn't fix it here myself because I wasn't sure where to do that). I guess we could have been just adding braces all along.
Thanks.
-boris
next reply other threads:[~2016-05-28 0:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 0:17 Boris Ostrovsky [this message]
2016-05-28 0:30 ` [GIT PULL] Please pull NFS client changes for Linux 4.7 Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2016-05-26 15:29 Anna Schumaker
2016-05-27 17:14 ` Boris Ostrovsky
2016-05-27 23:50 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19769bfc-efc7-495f-9574-f771236a9765@default \
--to=boris.ostrovsky@oracle.com \
--cc=Anna.Schumaker@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).