From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B0AC64E7D for ; Sat, 28 Nov 2020 21:56:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AECA208CA for ; Sat, 28 Nov 2020 21:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390080AbgK1Vzo (ORCPT ); Sat, 28 Nov 2020 16:55:44 -0500 Received: from foss.arm.com ([217.140.110.172]:37590 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387686AbgK1UWA (ORCPT ); Sat, 28 Nov 2020 15:22:00 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E6D7F1042; Sat, 28 Nov 2020 12:21:14 -0800 (PST) Received: from [192.168.2.22] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B4CE53F23F; Sat, 28 Nov 2020 12:21:13 -0800 (PST) Subject: Re: [RESEND PATCH 11/19] arm64: dts: allwinner: a100: add watchdog node To: Frank Lee , tiny.windzz@gmail.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org, Jernej Skrabec References: <7a7fc132cf3fa07f069d473d4600ec1449fb45ff.1604988979.git.frank@allwinnertech.com> From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Organization: ARM Ltd. Message-ID: <197ac654-7258-205c-c34f-2559d2ff5010@arm.com> Date: Sat, 28 Nov 2020 20:20:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <7a7fc132cf3fa07f069d473d4600ec1449fb45ff.1604988979.git.frank@allwinnertech.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2020 06:38, Frank Lee wrote: > From: Yangtao Li > > Declare A100's watchdog in the device-tree. > > Signed-off-by: Yangtao Li I don't have any manual nor hardware, but this node looks alright, when compared to the H6 one. Reviewed-by: Andre Przywara Cheers, Andre > --- > arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > index 01ff53b5a7a8..6aa3337ce0e9 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > @@ -144,6 +144,14 @@ ths_calibration: calib@14 { > }; > }; > > + watchdog@30090a0 { > + compatible = "allwinner,sun50i-a100-wdt", > + "allwinner,sun6i-a31-wdt"; > + reg = <0x030090a0 0x20>; > + interrupts = ; > + clocks = <&dcxo24M>; > + }; > + > pio: pinctrl@300b000 { > compatible = "allwinner,sun50i-a100-pinctrl"; > reg = <0x0300b000 0x400>; >