From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 965FDC433F5 for ; Sat, 4 Sep 2021 22:31:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F76260249 for ; Sat, 4 Sep 2021 22:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235233AbhIDWMh (ORCPT ); Sat, 4 Sep 2021 18:12:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230316AbhIDWMf (ORCPT ); Sat, 4 Sep 2021 18:12:35 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F7D3C061575 for ; Sat, 4 Sep 2021 15:11:33 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id jg16so5423223ejc.1 for ; Sat, 04 Sep 2021 15:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=pnO88SnYwL+lxhkaT9WWjyqqGtrBLDXuOHryPbPgt0I=; b=KSVwLRFmYD1meZv2Fl8QTFJhJd+OugYquC+jL68KYWRTnpq40a9SitOu1NM8LtWajW zmqRKGu3QjDkDn6/Ulb/RwyZQdDfTf1Lmz5x9Eq4UA/Y48MaTmuGYArI3DRNr9xXa9eG kIwX+OK42KjMtSuPeb/z5S1VuZqrYrhMT8YarGAW/KvMx2Gg/W+lJGvD0dVDHBZ5fuW3 3xyG3BbLWBBEkDh21HlQWaC5XyxewmTL5NLTf/XTrEDLT+PDl9iKWKqc6FYTWYqrfK/U 5b6vzw6PWrnfnPDTVI33jYlU4MA1pn6nXlVa44o50fNZfzL5sY641Q4o7mY0w92I+gzk iSkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pnO88SnYwL+lxhkaT9WWjyqqGtrBLDXuOHryPbPgt0I=; b=I46Yg028BOsHYHI5hFXAt0dRAgzJajriAxZABVWKEM4fmURV/qbVv2VUBs4AhPz6OV /LVnJivJK2IHPM+jiqCS2wRcGdUXPml7gjSDBjjuTZOdsi1AFhdVyf74kHpmbGz3E8OC FV+W2S/DHSFObqlAz33Np6Y+f7gIcmtVNs/N0yohWq8N6N82U0a4WFDpG9hJNqTRxhMU K9sR2Zn7bd7bYUoSoAnCQTK/kDuTw9nmvrexb4YHLqkpCPDTFp/ZFCIMykV3NkiGoI5a h6Ae8RGmiId5D1laqYkIFD33jNylwdud6HhK62IV55bkEjBa3aR0x8Bi6wOx4bXcduaa DuHA== X-Gm-Message-State: AOAM5326GWGr/63GC7Ep5gw/e8IJ57EMPl2o3BWaNlTdNLickuQGsP+N cznnep+gGUqIzDX6j8q/Muc= X-Google-Smtp-Source: ABdhPJxOA2KjnI+4V509sYDRR4A2+vFjmq9UU4wA+FCwMul/Bb/wcty9Lb/10f809Uo6+4YY4+4DHA== X-Received: by 2002:a17:907:1b02:: with SMTP id mp2mr6006270ejc.196.1630793492157; Sat, 04 Sep 2021 15:11:32 -0700 (PDT) Received: from localhost.localdomain (host-79-23-101-208.retail.telecomitalia.it. [79.23.101.208]) by smtp.gmail.com with ESMTPSA id j13sm1921761edt.72.2021.09.04.15.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Sep 2021 15:11:31 -0700 (PDT) From: "Fabio M. De Francesco" To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] staging: r8188eu: Shorten and simplify calls chain Date: Sun, 05 Sep 2021 00:11:30 +0200 Message-ID: <1985180.urcR3nkfMq@localhost.localdomain> In-Reply-To: <20210904212719.11426-1-fmdefrancesco@gmail.com> References: <20210904212719.11426-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 4, 2021 11:27:16 PM CEST Fabio M. De Francesco wrote: > io_ops abstraction is useless in this driver, since there is only one ops > registration. Without io_ops we can get rid of indirect calls mess and > shorten the calls chain. > > Shorten the calls chain of rtw_read8/16/32() down to the actual reads. > For this purpose unify the three usb_read8/16/32 into the new > usb_read(); make the latter parametrizable with 'size'; embed most of > the code of usbctrl_vendorreq() into usb_read() and use in it the new > usb_control_msg_recv() API of USB Core. > > Shorten the calls chain of rtw_write8/16/32() down to the actual writes. > For this purpose unify the four usb_write8/16/32/N() into the new > usb_write(); make the latter parametrizable with 'size'; embed most of > the code of usbctrl_vendorreq() into usb_write() and use in it the new > usb_control_msg_send() API of USB Core. > > The code with the modifications was thoroughly tested by Pavel Skripkin > using a TP-Link TL-WN722N v2 / v3 [Realtek RTL8188EUS] > > Fabio M. De Francesco (2): > staging: r8188eu: Shorten calls chain of rtw_read8/16/32() > staging: r8188eu: Shorten calls chain of rtw_write8/16/32/N() > > Pavel Skripkin (1): > staging: r8188eu: remove _io_ops structure > > drivers/staging/r8188eu/core/rtw_io.c | 241 +---------------- > drivers/staging/r8188eu/hal/usb_halinit.c | 6 +- > drivers/staging/r8188eu/hal/usb_ops_linux.c | 242 +++++++++++------- > drivers/staging/r8188eu/include/rtw_io.h | 76 +----- > drivers/staging/r8188eu/include/usb_ops.h | 2 - > .../staging/r8188eu/include/usb_ops_linux.h | 8 - > drivers/staging/r8188eu/os_dep/usb_intf.c | 2 +- > .../staging/r8188eu/os_dep/usb_ops_linux.c | 40 +-- > 8 files changed, 174 insertions(+), 443 deletions(-) > > -- > 2.33.0 > Dear Maintainers, Stupid mistakes on mistakes... Please discard this revision of the series because patch 3/3 is missing the version number. Thanks, Fabio