From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752030AbcF2VUN (ORCPT ); Wed, 29 Jun 2016 17:20:13 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56950 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbcF2VUL (ORCPT ); Wed, 29 Jun 2016 17:20:11 -0400 X-IBM-Helo: d24dlp01.br.ibm.com X-IBM-MailFrom: bauerman@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org From: Thiago Jung Bauermann To: Dave Young Cc: kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Eric Biederman Subject: Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer. Date: Wed, 29 Jun 2016 18:18:43 -0300 User-Agent: KMail/4.14.3 (Linux/3.13.0-88-generic; KDE/4.14.13; x86_64; ; ) In-Reply-To: <20160629194751.GB5488@dhcp-128-65.nay.redhat.com> References: <1466538521-31216-1-git-send-email-bauerman@linux.vnet.ibm.com> <2060648.f0n9OPAato@hactar> <20160629194751.GB5488@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062921-1523-0000-0000-000001FEDA9C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062921-1524-0000-0000-000026DB1D6D Message-Id: <1994502.0E8c14rYFh@hactar> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-29_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606290197 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 29 Juni 2016, 15:47:51 schrieb Dave Young: > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > index e8acb2b43dd9..e16d845d587f 100644 > > --- a/include/linux/kexec.h > > +++ b/include/linux/kexec.h > > @@ -146,7 +146,30 @@ struct kexec_file_ops { > > > > kexec_verify_sig_t *verify_sig; > > > > #endif > > }; > > > > -#endif > > + > > +/** > > + * struct kexec_buf - parameters for finding a place for a buffer in > > memory + * @image: kexec image in which memory to search. > > + * @mem: On return will have address of the buffer in memory. > > + * @memsz: Size for the buffer in memory. > > + * @buf_align: Minimum alignment needed. > > + * @buf_min: The buffer can't be placed below this address. > > + * @buf_max: The buffer can't be placed above this address. > > + * @top_down: Allocate from top of memory. > > + */ > > +struct kexec_buf { > > + struct kimage *image; > > + unsigned long mem; > > + unsigned long memsz; > > + unsigned long buf_align; > > + unsigned long buf_min; > > + unsigned long buf_max; > > + bool top_down; > > +}; > > Rethink about the first patch, you dropped the user buffer in kexec_buf > But later your passing IMA digests buffer patchset may need use it. > > So keep it in kexec_buf should be better. I'm not following. The IMA buffer patchset doesn't use kexec_locate_mem_hole nor struct kexec_buf. > For the IMA buffer patchset I'm still reading and learning the > background, will reply them later. Thank you! []'s Thiago Jung Bauermann IBM Linux Technology Center