From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751627AbcLWFSu (ORCPT ); Fri, 23 Dec 2016 00:18:50 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:41847 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbcLWFSr (ORCPT ); Fri, 23 Dec 2016 00:18:47 -0500 X-AuditID: b6c32a59-f79486d000002ff5-ed-585cb3b476de Subject: Re: [PATCH 1/2] drm/panel: Add support for S6E3HA2 panel driver on TM2 board To: Rob Herring Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, Donghwa Lee , linux-kernel@vger.kernel.org, krzk@kernel.org, kgene@kernel.org, Hyungwon Hwang , Hoegeun Kwon , Inki Dae , =?UTF-8?B?7LWc7LCs7Jqw?= From: hoegeun kwon Message-id: <199a2789-bf1a-963e-bbe8-f242239dff70@samsung.com> Date: Fri, 23 Dec 2016 14:18:46 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-version: 1.0 In-reply-to: <20161219185553.bxizmi2yegk5ca6b@rob-hp-laptop> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLJsWRmVeSWpSXmKPExsWy7bCmpu6WzTERBjvuC1tc//Kc1WL+kXOs FtfP21lc+fqezeL98i42i6Uz+lgtJt2fwGLR//g1s8X58xvYLS7vmsNmMeP8PiaL/3t2sDvw eGxa1cnmcb/7OJNH35ZVjB6fN8kFsESl2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpa WpgrKeQl5qbaKrn4BOi6ZeYAXaakUJaYUwoUCkgsLlbSt7Mpyi8tSVXIyC8usVWKNjQ00jM0 MNczMjLSMzGOtTIyBSpJSM04eHEla8FdmYr3d0+wNjB+F+ti5OSQEDCRmHz+DjOELSZx4d56 ti5GLg4hgaWMEv/+N7KAJIQE2pkkvr/UhWlY+ucdC0TRckaJFY2/oZy7jBINi7vZQaqEBcIl djzvZgKxRQQUJX63TWMFKWIW+M4kMeHrUrAEm4CuxJTF38BsXgE7iV1b/4OtYxFQlbiyug9s kKhAhMShY7eZIWoEJX5MvgdWwylgI9HefZYRxGYWsJJ49q+VFcKWl9i85i0zyDIJgWPsEgtv fAQaxAHkyEpsOgD1p4vEvQ3PWSBsYYlXx7ewQ9jSEn+X3mKE6O1mlPjetAJq0ARGiZ8NG6C6 jSXuP7jHDLGNT6L39xMmiAW8Eh1tQhAlHhKXdnRClTtKfFp9lgkSRL1MEl0dX1gmMMrPQvLQ LCRPzELyxAJG5lWMYqkFxbnpqcWmBaZ6xYm5xaV56XrJ+bmbGMFJUytyB+OVmUGHGAU4GJV4 eDcoxUQIsSaWFVfmHmKU4GBWEuFdswEoxJuSWFmVWpQfX1Sak1p8iNEUGMgTmaVEk/OBCT2v JN7QxMzQxMgSCM0NzZXEeRdUWEcICaQnlqRmp6YWpBbB9DFxcEo1MIbuDlWf6LXjdLhW482i NVvq0+edtwpmOmXV+uFcLVOBwEz2Scn1osdC1KQnVXkJ9L08V/fH88udfZ2V2+smhXxd9miD rOG6YPZNgp13eC7/cXH9s9o1/E1629w0LU3DgM1Kk3cm672pXOlkFK63vPGH6UKn7zFsMwO3 c3HPZFW2KKv6+WTHQSWW4oxEQy3mouJEAFkXyR+wAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t9jAd3Nm2MiDHY9MLa4/uU5q8X8I+dY La6ft7O48vU9m8X75V1sFktn9LFaTLo/gcWi//FrZovz5zewW1zeNYfNYsb5fUwW//fsYHfg 8di0qpPN4373cSaPvi2rGD0+b5ILYIlys8lITUxJLVJIzUvOT8nMS7dVCg1x07VQUshLzE21 VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8bBiytZC+7KVLy/e4K1gfG7WBcjJ4eEgInE 0j/vWCBsMYkL99azdTFycQgJLGWUmLVpPQuEc59R4tqlfiaQKmGBcIlfs2+AdYgIKEr8bpvG ClHUyyRxdMcpMIdZ4DuTxIVV79hAqtgEdCWmLP4G1s0rYCexa+t/sG4WAVWJK6v72LsYOThE BSIkGg6nQ5QISvyYfA+shFPARqK9+ywjiM0sYCbx5eVhVghbXmLzmrfMExgFZiFpmYWkbBaS sgWMzKsYJVILkguKk9JzjfJSy/WKE3OLS/PS9ZLzczcxgqPxmfQOxsO73A8xCnAwKvHwnuCO jhBiTSwrrsw9xCjBwawkwrtmQ0yEEG9KYmVValF+fFFpTmrxIUZToD8mMkuJJucDE0VeSbyh ibmJubGBhbmlpYmRkjhv4+xn4UIC6YklqdmpqQWpRTB9TBycUg2MllJroudqfrOc/m3RegPO QzrlYiXL69ou9Sx/fP1Rgc6uX8LB/91ucS7MTnU6omr988P5383pthGHzmf7WKsskth/Qu/K naiU6sv6JvHvxYMrr2vJVf4q2y2nxtm447NBzb/nqV6P/vb/dH3qzeJ3XHGibd0V2RQe1Wn6 7suv/znv4HBop95NJZbijERDLeai4kQAFsuIbNwCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161223051843epcas5p48328379ca04515181caff90c5086e139 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzMo7IKs7JuQKS/sgqzsm5A=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTMy9Bc3Npc3RhbnQgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20161219185609epcas1p474536f74eb9055ff06fa0de04efade26 X-RootMTR: 20161219185609epcas1p474536f74eb9055ff06fa0de04efade26 References: <1481695445-13088-1-git-send-email-hoegeun.kwon@samsung.com> <1481695445-13088-2-git-send-email-hoegeun.kwon@samsung.com> <20161219185553.bxizmi2yegk5ca6b@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/20/2016 03:55 AM, Rob Herring wrote: > On Wed, Dec 14, 2016 at 03:04:04PM +0900, Hoegeun Kwon wrote: >> This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel >> driver. This panel has 1440x2560 resolution in 5.7-inch physical >> panel in the TM2 device. >> >> Signed-off-by: Donghwa Lee >> Signed-off-by: Hyungwon Hwang >> Signed-off-by: Hoegeun Kwon >> --- >> .../bindings/display/panel/samsung,s6e3ha2.txt | 52 ++ >> drivers/gpu/drm/panel/Kconfig | 6 + >> drivers/gpu/drm/panel/Makefile | 1 + >> drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 756 +++++++++++++++++++++ >> 4 files changed, 815 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt >> create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c >> >> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt >> new file mode 100644 >> index 0000000..1f41f24 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt >> @@ -0,0 +1,52 @@ >> +Samsung S6E3HA2 5.7" 1440x2560 AMOLED panel >> + >> +Required properties: >> + - compatible: "samsung,s6e3ha2" >> + - reg: the virtual channel number of a DSI peripheral >> + - vdd3-supply: core voltage supply >> + - vci-supply: voltage supply for analog circuits >> + - reset-gpios: a GPIO spec for the reset pin >> + - enable-gpios: a GPIO spec for the panel enable pin >> + - te-gpios: a GPIO spec for the tearing effect synchronization signal gpio pin > Need to specify the GPIOs as active high or low. Hi Rob Herring, Thanks for point out. I will add "(active high or low)" after the description of the GPIOs. >> + >> +Optional properties: >> + - display-timings: timings for the connected panel as described by [1] >> + >> +The device node can contain one 'port' child node with one child >> +'endpoint' node, according to the bindings defined in [2]. This >> +node should describe panel's video bus. >> + >> +[1]: Documentation/devicetree/bindings/display/panel/display-timing.txt >> +[2]: Documentation/devicetree/bindings/media/video-interfaces.txt >> + >> +Example: >> + >> + panel@0 { >> + compatible = "samsung,s6e3ha2"; >> + reg = <0>; > reg doesn't really work here unless this node is a child of the DSI > controller node. But if it is a child node, then you don't need the OF > graph. The reg value is used in virtual child panel node so I think the reg value is needed. Please refer to the document below. Documentation/devicetree/bindings/display/mipi-dsi-bus.txt Best Regards, Hoegeun Kwon >> + vdd3-supply = <&ldo27_reg>; >> + vci-supply = <&ldo28_reg>; >> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_HIGH>; >> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >> + >> + display-timings { >> + timing-0 { >> + clock-frequency = <0>; >> + hactive = <1440>; >> + vactive = <2560>; >> + hfront-porch = <1>; >> + hback-porch = <1>; >> + hsync-len = <1>; >> + vfront-porch = <1>; >> + vback-porch = <15>; >> + vsync-len = <1>; >> + }; >> + }; >> + >> + port { >> + dsi_in: endpoint { >> + remote-endpoint = <&dsi_out>; >> + }; >> + }; >> + }; > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel