From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"wen.yang99@zte.com.cn" <wen.yang99@zte.com.cn>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jiang.biao2@zte.com.cn" <jiang.biao2@zte.com.cn>,
"zhong.weidong@zte.com.cn" <zhong.weidong@zte.com.cn>
Subject: Re: [PATCH] scsi: Replace sdev_printk with printk_deferred to avoid
Date: Tue, 27 Mar 2018 14:31:32 +0000 [thread overview]
Message-ID: <199ab05df000f2e8b5497a7aaecd0951321aadae.camel@wdc.com> (raw)
In-Reply-To: <1520499006-19857-1-git-send-email-wen.yang99@zte.com.cn>
On Thu, 2018-03-08 at 16:50 +0800, Wen Yang wrote:
> When scsi disks went wrong frequently, and with serial console
> attached, tasks may be blocked in the following flow for more than 10s: [ ... ]
>From https://bugzilla.kernel.org/show_bug.cgi?id=199003: "Hm,
printk_deferred is a bit dangerous; it moves console_unlock() to
IRQ. [ ... ] So I'd say that those two approaches
printk_deferred + touch_nmi_watchdog
combined can do quite some harm. One thing for sure - they don't really fix
any problems."
Does that mean that this patch should be dropped?
Thanks,
Bart.
next prev parent reply other threads:[~2018-03-27 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 8:50 [PATCH] scsi: Replace sdev_printk with printk_deferred to avoid Wen Yang
2018-03-27 0:27 ` Bart Van Assche
2018-03-27 14:31 ` Bart Van Assche [this message]
[not found] ` <201803281029555635678@zte.com.cn>
2018-03-28 2:44 ` 答复: " Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199ab05df000f2e8b5497a7aaecd0951321aadae.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jiang.biao2@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=wen.yang99@zte.com.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).