linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jia, Fang" <fang.jia@windriver.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: phy: fixed link 1000 or 100 set with autoneg off
Date: Thu, 26 Oct 2023 10:41:23 +0800	[thread overview]
Message-ID: <19a2675e-928c-7986-95d5-b05a09cf1120@windriver.com> (raw)
In-Reply-To: <dfc37ead-2abe-4053-b0a6-911c9c387451@lunn.ch>

Thanks very much for all your reply.

Do you think is it possible that we don't ignore the speed and duplex 
settings in BMCR, but we only add the bit BMCR_ANENABLE in BMCR ? just 
for example, return (bmcr |= BMCR_ANENABLE);


On 10/23/23 22:28, Andrew Lunn wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
>> Thanks very much for your reply.
>>
>> Actually, due to some reason, the phydev's default aneg state is off.
>> And we just found if use ethtool to set, it had the same result.
> 
> I find it surprising it defaults to aneg off. Are you sure something
> has not turned it off before you look at it?
> 

These days I was trying to find how and why set to aneg off. It seems 
like due to "the some reason", we have to do this.

> The emulator does not support writing to any registers. However,
> fixed_mdio_write() does not return an error, it just does nothing.  It
> needs testing, but maybe try making it return -EOPNOTSUPP. That should
> prevent auto-neg being turned off, but it might also break everything
> if it tries to do some other write during probe or link up. It could
> be it needs a more select response, allowing writes to some bits, like
> the reset bit, and start auto-neg, but not others like disable
> auto-neg.
> 
>          Andrew

  reply	other threads:[~2023-10-26  2:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  7:01 phy: fixed link 1000 or 100 set with autoneg off Jia, Fang
2023-10-23  7:42 ` Bagas Sanjaya
2023-10-23  7:52 ` Heiner Kallweit
2023-10-23  8:34   ` Jia, Fang
2023-10-23 14:28     ` Andrew Lunn
2023-10-26  2:41       ` Jia, Fang [this message]
2023-10-23 14:57   ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19a2675e-928c-7986-95d5-b05a09cf1120@windriver.com \
    --to=fang.jia@windriver.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).