linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Melody Olvera <quic_molvera@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards
Date: Tue, 4 Oct 2022 10:16:47 -0500	[thread overview]
Message-ID: <19a54de8-d769-ab65-6332-6a8ff68e1437@quicinc.com> (raw)
In-Reply-To: <59d306a6-989a-ecf8-0262-7562d110bf0e@linaro.org>


On 10/1/2022 4:26 AM, Krzysztof Kozlowski wrote:
> On 01/10/2022 05:06, Melody Olvera wrote:
>> Document the QDU1000 and QRU1000 SoC bindings and the boards that use
>> them.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++
> This patch goes with DT.
Will move to the dt PS.
>
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index fb1d00bcc847..1cfd92f4ab5d 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -61,6 +61,8 @@ description: |
>>          sm8250
>>          sm8350
>>          sm8450
>> +        qdu1000
>> +        qru1000
>>  
>>    The 'board' element must be one of the following strings:
>>  
>> @@ -76,6 +78,7 @@ description: |
>>          mtp
>>          qrd
>>          sbc
>> +        x100
>>  
>>    The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
>>    where the minor number may be omitted when it's zero, i.e.  v1.0 is the same
>> @@ -718,6 +721,19 @@ properties:
>>                - qcom,sm8450-qrd
>>            - const: qcom,sm8450
>>  
>> +      - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
>> +          - items:
>> +              - enum:
>> +                  - qcom,qdu1000-idp
>> +                  - qcom,qdu1000-x100
>> +              - const: qcom,qdu1000
> Wrong order - you put it in some odd place.
Will put in alphabetical order.
>
>> +
>> +      - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
>> +          - items:
>> +              - enum:
>> +                  -qcom,qru1000-idp
> Missing space.
Whoops; will fix.
>
>> +              - const: qcom,qru1000
>> +
>>  additionalProperties: true
>>  
>>  ...
> Best regards,
> Krzysztof

Thanks,

Melody


  reply	other threads:[~2022-10-04 15:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01  3:06 [PATCH 0/5] Add misc support for QDU1000/QRU1000 SoCs Melody Olvera
2022-10-01  3:06 ` [PATCH 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles Melody Olvera
2022-10-01  9:25   ` Krzysztof Kozlowski
2022-10-03 22:02     ` Melody Olvera
2022-10-03 22:14       ` Dmitry Baryshkov
2022-10-04  6:53         ` Krzysztof Kozlowski
2022-10-04  7:36           ` Dmitry Baryshkov
2022-10-04 15:52             ` Melody Olvera
2022-10-04 16:08               ` Melody Olvera
2022-10-04 21:05               ` Dmitry Baryshkov
2022-10-05  8:27                 ` Krzysztof Kozlowski
2022-10-05 21:08                   ` Trilok Soni
2022-10-01  3:06 ` [PATCH 2/5] dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards Melody Olvera
2022-10-01  9:26   ` Krzysztof Kozlowski
2022-10-04 15:16     ` Melody Olvera [this message]
2022-10-03 13:24   ` Rob Herring
2022-10-01  3:06 ` [PATCH 3/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding Melody Olvera
2022-10-01  9:27   ` Krzysztof Kozlowski
2022-10-04 15:19     ` Melody Olvera
2022-10-01  3:06 ` [PATCH 4/5] soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains Melody Olvera
2022-10-01  7:50   ` Dmitry Baryshkov
2022-10-02  3:14   ` kernel test robot
2022-10-07  3:11   ` Bjorn Andersson
2022-10-12 20:32     ` Melody Olvera
2022-10-01  3:06 ` [PATCH 5/5] soc: qcom: socinfo: Add QDU1000/QRU1000 and variant IDs Melody Olvera
2022-10-01  9:28   ` Krzysztof Kozlowski
2022-10-01  9:34 ` [PATCH 0/5] Add misc support for QDU1000/QRU1000 SoCs Krzysztof Kozlowski
2022-10-04 15:27   ` Melody Olvera
2022-10-04 16:05     ` Melody Olvera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19a54de8-d769-ab65-6332-6a8ff68e1437@quicinc.com \
    --to=quic_molvera@quicinc.com \
    --cc=agross@kernel.org \
    --cc=bhupesh.sharma@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).