From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC69FC4360C for ; Thu, 10 Oct 2019 22:11:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FB84214E0 for ; Thu, 10 Oct 2019 22:11:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726665AbfJJWK5 (ORCPT ); Thu, 10 Oct 2019 18:10:57 -0400 Received: from smtprelay0113.hostedemail.com ([216.40.44.113]:56900 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725978AbfJJWK5 (ORCPT ); Thu, 10 Oct 2019 18:10:57 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 31CB2182CED2A; Thu, 10 Oct 2019 22:10:56 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: news25_4231f6f182805 X-Filterd-Recvd-Size: 1564 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA; Thu, 10 Oct 2019 22:10:54 +0000 (UTC) Message-ID: <19dc4500bbfbb9d09f9730764a2b59353534358d.camel@perches.com> Subject: Re: [PATCH 05/19] EDAC, mc: Reduce indentation level in edac_mc_handle_error() From: Joe Perches To: Robert Richter , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck Cc: James Morse , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Thu, 10 Oct 2019 15:10:53 -0700 In-Reply-To: <20191010202418.25098-6-rrichter@marvell.com> References: <20191010202418.25098-1-rrichter@marvell.com> <20191010202418.25098-6-rrichter@marvell.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-10-10 at 20:25 +0000, Robert Richter wrote: > Reduce the indentation level in edac_mc_handle_error() a bit by using > continue. No functional changes. Seems fine, but trivially below: > diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c [] > @@ -1171,37 +1171,38 @@ void edac_mc_handle_error(const enum hw_event_mc_err_type type, [] > + strcpy(p, dimm->label); > + p += strlen(p); > + *p = '\0'; This *p = '\0' is unnecessary as the strcpy already did that.