From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF820C433E6 for ; Wed, 27 Jan 2021 08:57:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F13320759 for ; Wed, 27 Jan 2021 08:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233594AbhA0I5L (ORCPT ); Wed, 27 Jan 2021 03:57:11 -0500 Received: from a1.mail.mailgun.net ([198.61.254.60]:12626 "EHLO a1.mail.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233297AbhA0Iyy (ORCPT ); Wed, 27 Jan 2021 03:54:54 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1611737663; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=EUssQP2vZo9f1NeJLiuievSQB3Q8g6yl/yOnTsJJnrY=; b=oQTnx3Cwl82f5vFXL+b+FUrZJ31PtSrwZiTpivoWxsgr6URr/XaT/qgA4e8WkUWwCz30+Nee 4ao/cAm6hozmLvjvV2ABx5rrouWUXM8uFTRYw7ovJ0zTIPA1Pl/V6Nh6wBxugJI13Q3J8Iwv k0eymC628r3DergbnbERivLlGlw= X-Mailgun-Sending-Ip: 198.61.254.60 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 60112a21a8db642432e346ac (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 27 Jan 2021 08:53:53 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 31DF8C43462; Wed, 27 Jan 2021 08:53:53 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9273BC433CA; Wed, 27 Jan 2021 08:53:52 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 27 Jan 2021 16:53:52 +0800 From: Can Guo To: Avri Altman Cc: Asutosh Das , martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, stern@rowland.harvard.edu, "Bao D . Nguyen" , FUJITA Tomonori , Jens Axboe , "open list:BLOCK LAYER" , open list Subject: Re: [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing In-Reply-To: <75c66862d61c63fcfa61cd6dce254169@codeaurora.org> References: <75c66862d61c63fcfa61cd6dce254169@codeaurora.org> Message-ID: <19e1d785e5fb3d8ee79bf55758ef2dcf@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-27 15:59, Can Guo wrote: > On 2021-01-27 15:09, Avri Altman wrote: >>> >>> Resumes the scsi device before accessing it. >>> >>> Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde >>> Signed-off-by: Asutosh Das >>> Signed-off-by: Can Guo >>> Signed-off-by: Bao D. Nguyen >> Following this patch, is it possible to revert commit 74e5e468b664d? >> > > No, but this is a good finding... This change assumes > that the queue->queue_data is a scsi_device, which is > why we call scsi_auto_pm_get(). But for ufs_bsg's case, > queue->queue_data is a device... > If we call pm_runtime_get/put_sync(bcd->class_dev->parent) in bsg_get/put_device(), commit 74e5e468b664d can be reverted. This is just a rough idea. > Thanks, > Can Guo. > >> Thanks, >> Avri