From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB62CCA479 for ; Mon, 20 Jun 2022 15:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242727AbiFTPRp (ORCPT ); Mon, 20 Jun 2022 11:17:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243989AbiFTPRe (ORCPT ); Mon, 20 Jun 2022 11:17:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7987A1ADA6 for ; Mon, 20 Jun 2022 08:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655737688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nOQ6e6pAcimxOwwNtbbgCCN0/d+i6E7YaBaKogZ6pjQ=; b=CHzpFkTuIgnlvlua7vac/24/1w4QK3MBuSUMUbMuLXZSsrOW+lgNEFaCqnzEs9msAy85Pk oNMfpnWySNSL0e739JgeUYKZltSdXxPfreXwZvxoYhTZ8Z8+dvtf/o2KB5NYyzaAvtHyMF IHpyFK21kJXk9N1PtTUizVXOj6z71gA= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-496-ERtlFhHfOSeIiQeEv5lHtA-1; Mon, 20 Jun 2022 11:08:06 -0400 X-MC-Unique: ERtlFhHfOSeIiQeEv5lHtA-1 Received: by mail-ed1-f72.google.com with SMTP id b14-20020a056402278e00b004359006fd49so616857ede.8 for ; Mon, 20 Jun 2022 08:08:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nOQ6e6pAcimxOwwNtbbgCCN0/d+i6E7YaBaKogZ6pjQ=; b=UHoT+Mejsl2FfsL0rpPHNwm1IEbflj8fWRSLBl3l+EtbPNGPlm7Elu+3JjYsGjllu8 XZzR11W9TdCQSmomHI17WDdE+UOunaGlqz1AN4DWr4L6qS7tTbCKdTximQH8IUUx/7kA /6Th4TL/NQLiHBfvc4wetv2rNA9WVK3fhSy7UpFvtW151QWO6d6xXrbhc1kDQg6V5+O+ V4K6k/ehl6KJD8dcN5shDNRVNGAFdHWjUvISKywWoUSA3f51nwiYSIF0UxlBEhR/nSwy /UVHC/rStVrSH9h0bybOKM1tObehrWwurgOclIsglYt08ZKLsWI8dObAz/DKHg6LXB/P X0GA== X-Gm-Message-State: AJIora/p6qcEDIHwcNvAMzDa/VqvqnF0fR1VXwt1gfom23vs3umKrbJJ vxa4zO9lv/J/Uwmdh/Gfbclsu5CfT2dWs0URLXyhbQnQOjyTLIKC45J1s7OlHnVHJi1CcA5vPDb GEdxfh3QAgvp3xfuw6C6ktyAq X-Received: by 2002:a17:906:38d0:b0:715:8483:e01e with SMTP id r16-20020a17090638d000b007158483e01emr22134669ejd.265.1655737684721; Mon, 20 Jun 2022 08:08:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tAnhocu7zzqOnvIChRoIB6PdhC4SoZp9rxJRlpwZNjYXy9x9UEnuqQFGmUC9iV6bqJIQDJuA== X-Received: by 2002:a17:906:38d0:b0:715:8483:e01e with SMTP id r16-20020a17090638d000b007158483e01emr22134631ejd.265.1655737684433; Mon, 20 Jun 2022 08:08:04 -0700 (PDT) Received: from [10.0.0.147] (D57D5A4B.static.ziggozakelijk.nl. [213.125.90.75]) by smtp.gmail.com with ESMTPSA id d20-20020a50fb14000000b004357558a243sm4973553edq.55.2022.06.20.08.08.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jun 2022 08:08:03 -0700 (PDT) Message-ID: <19e590f1-e865-ad19-e9e4-df1f9274663c@redhat.com> Date: Mon, 20 Jun 2022 17:08:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/2] platform/x86: panasonic-laptop: allow to use all hotkeys Content-Language: en-US To: Stefan Seyfried , Kenneth Chan , Andy Shevchenko Cc: Platform Driver , Linux Kernel Mailing List , Stefan Seyfried References: <20200821181433.17653-8-kenneth.t.chan@gmail.com> <20220612090507.20648-1-stefan.seyfried@googlemail.com> <20220612090507.20648-3-stefan.seyfried@googlemail.com> <6969ca0e-4a4c-c995-02a2-6645f875338c@redhat.com> <5f03f5b9-87bb-e27d-ce51-9c1572221f21@redhat.com> <89398c05-92c6-120d-ed51-ab62f1f404eb@message-id.googlemail.com> From: Hans de Goede In-Reply-To: <89398c05-92c6-120d-ed51-ab62f1f404eb@message-id.googlemail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thank you for the quick testing. On 6/17/22 15:07, Stefan Seyfried wrote: > Hi Hans, > > On 17.06.22 13:07, Hans de Goede wrote: > >> Thank you for providing this info. Can you please give >> the attached patch series a try, this includes Stefan's 1/2 patch >> and replaces Stefan's 2/2 patch. >> >> This will hopefully fix the double key-presses for you, while >> also keeping everything working for Stefan without requiring >> a module option or DMI quirks. >> >> Stefan can you also give this series a try please? > > Works for me, almost out of the box. > I need to enable "report_key_events=1" in the video module, then the panasonic-acpi module starts reporting brightness up/down keys. Ok, so you need another module option that is not really helpful. The idea behind the acpi_video_handles_brightness_key_presses() check is that if the ACPI video bus device is present it is expected to already report brightness up/down keypresses and we want to avoid duplicates. Can you check with evtest or evemu-record that the brightness events are not already being delivered by the "Video Bus" input device ? > Volume and mute keys work without manual changes. Good. > (I tested against 5.18.2 because that's what was already prepared. That old machine takes quite some time, even to just compile the platform/x86 subdirectory ;-) but I don't think this is relevant. If you think it is, I can also test against latest 5.19-rc code) Testing against 5.18 is fine . >> Looking at this has also brought up an unrelated backlight question: >> >> Kenneth, since you have acpi-video reporting keypresses you will >> likely also have an acpi_video (or perhaps a native intel) backlight >> under /sys/class/backlight and I noticed that panasonic-laptop >> uncondirionally registers its backlight so you may very well end >> up with 2 backlight controls under /sys/class/backlight, which >> we generally try to avoid (so that userspace does not have to >> guess which one to use). >> >> Can you do: >> ls /sys/class/backlight > > toughbook:~ # ls -l /sys/class/backlight/ > total 0 > lrwxrwxrwx 1 root root 0 Jun 17 14:45 intel_backlight -> ../../devices/pci0000:00/0000:00:02.0/drm/card0/card0-LVDS-1/intel_backlight > lrwxrwxrwx 1 root root 0 Jun 17 14:49 panasonic -> ../../devices/virtual/backlight/panasonic > >> and let me know the output? >> >> Also if there are 2 backlights there then please do: >> cat /sys/class/backlight//max_brightness >> to find out the range (0-value) > > toughbook:/sys/class/backlight # grep . */max_brightness > intel_backlight/max_brightness:19531 > panasonic/max_brightness:255 > >> and then try if they both work by doing: >> >> echo $number > /sys/class/backlight//brightness >> >> with different $number values in the range and see >> if this actually changes the brightness. > > intel_backlight: does not work > panasonic: does work Ok, so that suggests that the ACPI video bus on your device is defunct, so I guess it also does not report key-presses (see above) ? This will also need some work then because we want to move to there only being 1 (actually working) backlight-class device. Rather then having multiple and let userspace guess which one it needs to use. >> While we are at it, Stefan can you do the same please? > > See above. > But hey, this is an i855GM graphics chip, I'm happy if it is still working *at all* (for example I need to avoid the xf86-intel driver and use the modesetting driver instead to get a usable sytstem) > > And I'm totally happy if all I have to do in the future is a > > option video report_key_events=1 > > modprobe.conf file ;-) We really don't want people to have to specify module-options just to have things working. Stefam, at least for the backlight class-device issue we will need a DMI quirk, so can you run: sudo dmidecode > dmidecode.txt and then attach the output to your next email, or send me a copy privately ? Regards, Hans