From: Jacky Huang <ychuang570808@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
soc@kernel.org, krzysztof.kozlowski+dt@linaro.org,
schung@nuvoton.com, Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH v2 1/2] clk: nuvoton: Add clk-ma35d1.h for driver extern functions
Date: Thu, 22 Jun 2023 09:42:27 +0800 [thread overview]
Message-ID: <19e93057-46e4-1578-9e3e-138bd09cccfc@gmail.com> (raw)
In-Reply-To: <69c742e5-3270-4b1c-be31-1552d877677e@app.fastmail.com>
On 2023/6/21 下午 10:22, Arnd Bergmann wrote:
> On Wed, Jun 21, 2023, at 05:16, Jacky Huang wrote:
>> From: Jacky Huang <ychuang3@nuvoton.com>
>>
>> Moved the declaration of extern functions ma35d1_reg_clk_pll() and
>> ma35d1_reg_adc_clkdiv() from the .c files to the newly created header
>> file clk-ma35d1.h.
>>
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>
>> #define PLL_MAX_NUM 5
>> @@ -20,19 +22,19 @@ static DEFINE_SPINLOCK(ma35d1_lock);
>> #define REG_CLK_PWRCTL 0x00
>> #define REG_CLK_SYSCLK0 0x04
>> #define REG_CLK_SYSCLK1 0x08
>> -#define REG_CLK_APBCLK0 0x0C
>> +#define REG_CLK_APBCLK0 0x0c
>> #define REG_CLK_APBCLK1 0x10
>> #define REG_CLK_APBCLK2 0x14
>> #define REG_CLK_CLKSEL0 0x18
>> -#define REG_CLK_CLKSEL1 0x1C
>> +#define REG_CLK_CLKSEL1 0x1c
>> #define REG_CLK_CLKSEL2 0x20
>> #define REG_CLK_CLKSEL3 0x24
>> #define REG_CLK_CLKSEL4 0x28
>> -#define REG_CLK_CLKDIV0 0x2C
>> +#define REG_CLK_CLKDIV0 0x2c
>> #define REG_CLK_CLKDIV1 0x30
>> #define REG_CLK_CLKDIV2 0x34
>> #define REG_CLK_CLKDIV3 0x38
>> -#define REG_CLK_CLKDIV4 0x3C
>> +#define REG_CLK_CLKDIV4 0x3c
>> #define REG_CLK_CLKOCTL 0x40
>> #define REG_CLK_STATUS 0x50
>> #define REG_CLK_PLL0CTL0 0x60
> This part of the patch does not relate to the decription, it
> looks like a minor cleanup that should be a separate patch.
>
> The actual change looks good and required, but I can't apply it
> if it's mixed with unrelated changes like this.
>
> Arnd
Dear Arnd,
Thanks for the advice.
I will extract the unrelated parts from this patch and create another
patch for them.
Best Regards,
Jacky Huang
next prev parent reply other threads:[~2023-06-22 1:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 3:16 [PATCH v2 0/2] clk: nuvoton: Use clk_parent_data instead and add a header file Jacky Huang
2023-06-21 3:16 ` [PATCH v2 1/2] clk: nuvoton: Add clk-ma35d1.h for driver extern functions Jacky Huang
2023-06-21 14:22 ` Arnd Bergmann
2023-06-22 1:42 ` Jacky Huang [this message]
2023-06-22 10:10 ` Arnd Bergmann
2023-06-21 3:16 ` [PATCH v2 2/2] clk: nuvoton: Use clk_parent_data instead of string for parent clock Jacky Huang
[not found] ` <2023062103-obtuse-parasitic-e675@gregkh>
2023-06-22 1:46 ` Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19e93057-46e4-1578-9e3e-138bd09cccfc@gmail.com \
--to=ychuang570808@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=schung@nuvoton.com \
--cc=soc@kernel.org \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).