From: Lukasz Luba <lukasz.luba@arm.com>
To: Steev Klimaszewski <steev@kali.org>
Cc: Thara Gopinath <thara.gopinath@linaro.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, sudeep.holla@arm.com,
will@kernel.org, catalin.marinas@arm.com, linux@armlinux.org.uk,
gregkh@linuxfoundation.org, rafael@kernel.org,
viresh.kumar@linaro.org, amitk@kernel.org,
daniel.lezcano@linaro.org, amit.kachhap@gmail.com,
bjorn.andersson@linaro.org, agross@kernel.org
Subject: Re: [PATCH v3 0/5] Refactor thermal pressure update to avoid code duplication
Date: Tue, 9 Nov 2021 16:22:12 +0000 [thread overview]
Message-ID: <19ecab72-4a2f-1f4a-b999-d3967a4a1a76@arm.com> (raw)
In-Reply-To: <ac3f1771-0516-48dd-ee4d-5752e0433472@kali.org>
On 11/9/21 3:46 PM, Steev Klimaszewski wrote:
>
> On 11/9/21 2:29 AM, Lukasz Luba wrote:
>> Hi Steev,
>>
>> That's interesting what you've done with Rockchip RK3399.
>> I would like to reproduce your experiment on my RockPI 4B v1.3.
>> Could you tell me how you to add this boost frequency that you have
>> mentioned in some previous emails?
>>
>> I want to have similar setup to yours and I'll check all the subsystems
>> involved in the decision making process for triggering this boost freq.
>>
>> Thank you for your support.
>>
>> Regards,
>> Lukasz
>
>
> Hi Lukasz,
>
> It was actually something that Armbian had been doing as an overlay for
> their setup, and I thought, why does it need to be an overlay, when we
> could simply hide it behind turbo-mode so that if users want to
> overclock, they simply echo 1 and if it's unstable or cooling/power
> isn't enough, they can echo 0 or leave it off (boost defaults to off) -
> so that being said:
>
> I apply this patch
> https://gitlab.com/kalilinux/build-scripts/kali-arm/-/blob/master/patches/pinebook-pro/pbp-5.14/rk3399-opp-overclock-2GHz-turbo-mode.patch
> which adds the 1.5GHz for little cores and 2GHz for the big to the
> rk3399 dtsi
>
> To enable at boot time, I simply have "echo 1 >
> /sys/devices/system/cpu/cpufreq/boost" in my /etc/rc.local And to
> disable, simply echo 0 in there (it defaults to 0 so it's off and most
> users won't know it exists.)
>
> I'm pretty sure this is "abusing" turbo-mode, but it works well enough...
>
> Hope that helps,
>
Yes, that help. Thank you for the info.
I'll play a bit with this boosting and try to figure out
the mechanisms.
For the $subject patch set, I'm going to send v4, since
it's not affecting the boost usage. The newly introduced
interface must handle these boost frequency values and not
simply ignore them with also printing a warning.
They are valid frequencies and we should just put 0 to
the thermal pressure in such cases.
Regards,
Lukasz
next prev parent reply other threads:[~2021-11-09 16:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 16:10 [PATCH v3 0/5] Refactor thermal pressure update to avoid code duplication Lukasz Luba
2021-11-03 16:10 ` [PATCH v3 1/5] arch_topology: Introduce thermal pressure update function Lukasz Luba
2021-11-03 16:10 ` [PATCH v3 2/5] thermal: cpufreq_cooling: Use new " Lukasz Luba
2021-11-03 16:10 ` [PATCH v3 3/5] cpufreq: qcom-cpufreq-hw: Update offline CPUs per-cpu thermal pressure Lukasz Luba
2021-11-03 16:10 ` [PATCH v3 4/5] cpufreq: qcom-cpufreq-hw: Use new thermal pressure update function Lukasz Luba
2021-11-05 19:12 ` Thara Gopinath
2021-11-08 14:12 ` Lukasz Luba
2021-11-08 21:23 ` Thara Gopinath
2021-11-09 8:46 ` Lukasz Luba
2021-11-03 16:10 ` [PATCH v3 5/5] arch_topology: Remove unused topology_set_thermal_pressure() and related Lukasz Luba
2021-11-05 15:39 ` [PATCH v3 0/5] Refactor thermal pressure update to avoid code duplication Steev Klimaszewski
2021-11-05 16:26 ` Lukasz Luba
2021-11-05 17:33 ` Steev Klimaszewski
2021-11-05 19:18 ` Thara Gopinath
2021-11-05 19:51 ` Steev Klimaszewski
2021-11-05 21:06 ` Thara Gopinath
2021-11-05 22:46 ` Steev Klimaszewski
2021-11-08 10:44 ` Lukasz Luba
2021-11-08 14:11 ` Thara Gopinath
2021-11-08 15:22 ` Steev Klimaszewski
2021-11-08 21:31 ` Thara Gopinath
2021-11-08 23:21 ` Steev Klimaszewski
2021-11-09 8:29 ` Lukasz Luba
2021-11-09 15:46 ` Steev Klimaszewski
2021-11-09 16:22 ` Lukasz Luba [this message]
2021-11-09 18:13 ` Lukasz Luba
2021-11-09 19:09 ` Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19ecab72-4a2f-1f4a-b999-d3967a4a1a76@arm.com \
--to=lukasz.luba@arm.com \
--cc=agross@kernel.org \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rafael@kernel.org \
--cc=steev@kali.org \
--cc=sudeep.holla@arm.com \
--cc=thara.gopinath@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).