From: "Vegard Nossum" <vegard.nossum@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: arges@linux.vnet.ibm.com, "Maynard Johnson" <maynardj@us.ibm.com>,
"Gianni Tedesco" <gxt@cs.nott.ac.uk>,
linux-kernel@vger.kernel.org,
oprofile-list@lists.sourceforge.net,
"Mike Travis" <travis@sgi.com>
Subject: Re: oprofile BUG() in current kernel.
Date: Tue, 13 May 2008 11:01:11 +0200 [thread overview]
Message-ID: <19f34abd0805130201q1a7e7617k8d260b3e229077bc@mail.gmail.com> (raw)
In-Reply-To: <20080513014010.e0723e01.akpm@linux-foundation.org>
On Tue, May 13, 2008 at 10:40 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Mon, 12 May 2008 11:38:03 -0500 Chris J Arges <arges@linux.vnet.ibm.com> wrote:
> > > >> Does reverting 608dfddd845da5ab6accef70154c8910529699f7 fix it for you too?
> > > >>
> > > Has this fix been officially reverted?
> >
>
> > Let me know if this change is going to be reverted, as I have a patch
> > ready to support cpu hotplug for oprofile based on code post
> > DEFINE_PER_CPU patch.
>
> Please don't top-post. I repaired it so that I could reply sensibly.
>
> In trying to reprocude this on a uniprocessor machine, it seems that
> someone broke oprofile:
>
> /usr/bin/opcontrol: line 911: /dev/oprofile/0/enabled: No such file or directory
> /usr/bin/opcontrol: line 911: /dev/oprofile/0/event: No such file or directory
> /usr/bin/opcontrol: line 911: /dev/oprofile/0/count: No such file or directory
> /usr/bin/opcontrol: line 911: /dev/oprofile/0/kernel: No such file or directory
> /usr/bin/opcontrol: line 911: /dev/oprofile/0/user: No such file or directory
> /usr/bin/opcontrol: line 911: /dev/oprofile/0/unit_mask: No such file or directo
>
> sony:/home/akpm> l /dev/oprofile
> total 0
> drwxr-xr-x 1 root root 0 May 13 01:25 1
> -rw-r--r-- 1 root root 0 May 13 01:25 backtrace_depth
> -rw-r--r-- 1 root root 0 May 13 01:25 buffer
> -rw-r--r-- 1 root root 0 May 13 01:25 buffer_size
> -rw-r--r-- 1 root root 0 May 13 01:25 buffer_watershed
> -rw-r--r-- 1 root root 0 May 13 01:25 cpu_buffer_size
> -rw-r--r-- 1 root root 0 May 13 01:25 cpu_type
> -rw-rw-rw- 1 root root 0 May 13 01:25 dump
> -rw-r--r-- 1 root root 0 May 13 01:25 enable
> -rw-r--r-- 1 root root 0 May 13 01:25 pointer_size
> drwxr-xr-x 1 root root 0 May 13 01:25 stats
>
> Looks like the "0" got renamed to "1". Who did that?
There's also a commit d18d00f5dbcd1a95811617e9812cf0560bd465ee with
the following text, which seems related?
"The existing code passed a reference to cpu 0's instance of struct op_msrs
to model->shutdown, whilst the other functions are passed a reference to
<this cpu's> instance of a struct op_msrs. This seemed to be a bug to me
even though as long as cpu 0 and <this cpu> are of the same type it would
have the same effect...?"
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
next prev parent reply other threads:[~2008-05-13 9:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 12:02 oprofile BUG() in current kernel Gianni Tedesco
2008-05-12 12:19 ` Vegard Nossum
2008-05-12 13:31 ` Gianni Tedesco
2008-05-12 14:11 ` Maynard Johnson
2008-05-12 16:38 ` Chris J Arges
2008-05-13 8:40 ` Andrew Morton
2008-05-13 9:01 ` Vegard Nossum [this message]
2008-05-13 9:41 ` Gianni Tedesco
2008-05-13 10:25 ` Eric Dumazet
2008-05-13 10:59 ` Gianni Tedesco
[not found] ` <482986B3.1090601@cosmosbay.com>
2008-05-13 14:38 ` Gianni Tedesco
2008-05-13 15:23 ` Andrew Morton
2008-05-13 15:12 ` [PATCH] per_cpu: fix DEFINE_PER_CPU_SHARED_ALIGNED for modules Eric Dumazet
2008-05-14 5:18 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0805130201q1a7e7617k8d260b3e229077bc@mail.gmail.com \
--to=vegard.nossum@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arges@linux.vnet.ibm.com \
--cc=gxt@cs.nott.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=maynardj@us.ibm.com \
--cc=oprofile-list@lists.sourceforge.net \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).