RE: [PATCH v2 0/5] ACPI / EC: Add reference counting for requests and cleans up the grace periods support.

["Zheng, Lv" <lv.zheng@intel.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2086 bytes --]

Hi, Rafael

> From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net]
> Sent: Friday, February 06, 2015 9:27 AM
> 
> On Friday, February 06, 2015 08:57:37 AM Lv Zheng wrote:
> > This patchset contains 3 cleanups related to the EC driver:
> > 1. Command flushing (command grace period)
> >    This patchset flushes EC commands before suspending/resuming, so that
> >    there won't be timeout for the incomplete commands after resuming.
> > 2. Query flushing (query grace period)
> >    This patchset flushes EC event queries before suspending/resuming, so
> >    that there won't be broken events remained in the firmware queue.
> > 3. Command storming prevention
> >    This patchset corrects command storming prevention logic because of
> >    the GPE raw handler mode.
> > The request reference count debugging messages can be used to detect broken
> > EC transactions. It should always drop to 1 when the driver is idle during
> > the runtime.
> >
> > Note that after flushing before suspending, EC GPE is still enabled to keep
> > the old behavior.
> >
> > Lv Zheng (5):
> >   ACPI/EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag.
> >   ACPI/EC: Add command flushing support.
> >   ACPI/EC: Refine command storm prevention support.
> >   ACPI/EC: Add query flushing support.
> >   ACPI/EC: Add GPE reference counting debugging messages.
> >
> >  drivers/acpi/ec.c       |  295 ++++++++++++++++++++++++++++++++++++++++-------
> >  drivers/acpi/internal.h |    1 +
> >  2 files changed, 254 insertions(+), 42 deletions(-)
> 
> So this is on top of the EC patches you sent previously, right?

Yes.

The sequence is:
ACPICA 20150204 release: http://www.spinics.net/lists/linux-acpi/msg55623.html
ACPI EC GPE race fixes: http://www.spinics.net/lists/linux-acpi/msg55633.html
And this series.

Thanks and best regards
-Lv


> 
> 
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥