From: "Zheng, Lv" <lv.zheng@intel.com>
To: "Zheng, Lv" <lv.zheng@intel.com>,
Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Brown, Len" <len.brown@intel.com>, Lv Zheng <zetalog@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Bastien Nocera:" <hadess@hadess.net>,
"Valdis.Kletnieks@vt.edu" <Valdis.Kletnieks@vt.edu>
Subject: RE: [PATCH v2 3/3] ACPI / button: Send "open" state after boot/resume
Date: Wed, 1 Jun 2016 07:51:05 +0000 [thread overview]
Message-ID: <1AE640813FDE7649BE1B193DEA596E883BBB71A8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1AE640813FDE7649BE1B193DEA596E883BBB6FAA@SHSMSX101.ccr.corp.intel.com>
Hi,
[cut]
> > We could have a parameter (say "send_lid_open_on_resume" or
> > "use_bios_lid_value") in acpi/button.c which would allow people to
> > choose if they want the "new" behavior or the old one. And we could
> > also add some DMI matching for the messed up laptops/tablets where
> we
> > force one or the other quirk. When we agree that user space now
> > behaves gently with us, we could then remove entirely the quirk and
> > the dmi matching.
> >
> > How does that sound?
> [Lv Zheng]
> The choices are in my first revision.
> I could restore it back and re-send this series.
> Also I need to update PATCH 02 to eliminate wrong IS_ERR_VALUE().
[Lv Zheng]
I forgot to mention.
IMO, if the issue is because of uncertain gaps, not a confirmed BIOS bug, or a confirmed gap that has to be solved in a spirit of compromise, we should not add quirks.
We could just provide boot parameters for users to choose.
Because the quirk table could grow bigger and bigger, exceeding our control.
So I probably would just implement the parameter part, without adding the DMI entries.
Thanks and best regards
-Lv
next prev parent reply other threads:[~2016-06-01 7:51 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 8:27 [RFC PATCH 1/2] ACPI / button: Send "open" state after boot/resume Lv Zheng
2016-05-17 23:36 ` Rafael J. Wysocki
2016-05-18 1:25 ` Zheng, Lv
2016-05-18 22:56 ` Rafael J. Wysocki
2016-05-19 1:50 ` Zheng, Lv
2016-05-19 13:21 ` Rafael J. Wysocki
2016-05-26 13:31 ` Benjamin Tissoires
2016-05-30 1:39 ` Zheng, Lv
2016-05-18 12:57 ` Bastien Nocera
2016-05-18 21:41 ` Rafael J. Wysocki
2016-05-19 1:59 ` Zheng, Lv
2016-05-27 7:15 ` [PATCH v2 0/3] ACPI / button: Clarify initial lid state Lv Zheng
2016-05-27 7:15 ` [PATCH v2 1/3] ACPI / button: Remove initial lid state notification Lv Zheng
2016-05-27 7:15 ` [PATCH v2 2/3] ACPI / button: Refactor functions to eliminate redundant code Lv Zheng
2016-05-27 7:16 ` [PATCH v2 3/3] ACPI / button: Send "open" state after boot/resume Lv Zheng
2016-05-30 8:10 ` Benjamin Tissoires
2016-05-31 2:55 ` Zheng, Lv
2016-05-31 14:47 ` Benjamin Tissoires
2016-06-01 1:17 ` Zheng, Lv
2016-06-01 7:51 ` Zheng, Lv [this message]
2016-06-01 8:07 ` Benjamin Tissoires
2016-05-27 22:10 ` [PATCH v2 0/3] ACPI / button: Clarify initial lid state Valdis.Kletnieks
2016-06-01 10:10 ` [PATCH v3 1/3] ACPI / button: Remove initial lid state notification Lv Zheng
2016-06-23 0:36 ` Rafael J. Wysocki
2016-06-23 0:57 ` Zheng, Lv
2016-06-01 10:10 ` [PATCH v3 2/3] ACPI / button: Refactor functions to eliminate redundant code Lv Zheng
2016-06-01 10:10 ` [PATCH v3 3/3] ACPI / button: Add quirks for initial lid state notification Lv Zheng
2016-06-01 11:01 ` Bastien Nocera
2016-06-02 1:08 ` Zheng, Lv
2016-06-02 14:01 ` Bastien Nocera
2016-06-02 15:25 ` Benjamin Tissoires
2016-06-03 0:41 ` Zheng, Lv
2016-07-19 8:11 ` [PATCH v4 1/2] ACPI / button: Add KEY_LID_OPEN/KEY_LID_CLOSE for new usage model Lv Zheng
2016-07-19 8:46 ` Benjamin Tissoires
2016-07-21 13:35 ` Rafael J. Wysocki
2016-07-21 20:33 ` Dmitry Torokhov
2016-07-19 8:11 ` [PATCH v4 2/2] ACPI / button: Add document for ACPI control method lid device restrictions Lv Zheng
2016-07-19 8:44 ` Benjamin Tissoires
2016-07-21 20:32 ` Dmitry Torokhov
2016-07-22 0:24 ` Zheng, Lv
2016-07-22 4:37 ` Dmitry Torokhov
2016-07-22 6:55 ` Benjamin Tissoires
2016-07-22 8:47 ` Zheng, Lv
2016-07-22 9:08 ` Benjamin Tissoires
2016-07-22 9:38 ` Zheng, Lv
2016-07-24 11:28 ` Bastien Nocera
2016-07-25 0:38 ` Zheng, Lv
2016-07-22 17:02 ` Dmitry Torokhov
2016-07-23 12:17 ` Zheng, Lv
2016-07-22 8:37 ` Zheng, Lv
2016-07-22 17:22 ` Dmitry Torokhov
2016-07-23 11:57 ` Zheng, Lv
2016-07-22 6:24 ` [PATCH v5 1/3] ACPI / button: Add missing event to keep SW_LID running without additional event loss Lv Zheng
2016-07-22 10:26 ` Zheng, Lv
2016-07-23 12:37 ` Rafael J. Wysocki
2016-07-25 0:24 ` Zheng, Lv
2016-07-22 6:24 ` [PATCH v5 2/3] ACPI / button: Add KEY_LID_OPEN/KEY_LID_CLOSE for new usage model Lv Zheng
2016-07-22 6:24 ` [PATCH v5 3/3] ACPI / button: Add document for ACPI control method lid device restrictions Lv Zheng
2016-07-25 1:14 ` [PATCH v6] ACPI / button: Fix an issue that the platform triggered "close" event may not be delivered to the userspace Lv Zheng
2016-07-26 9:52 ` [PATCH v7 1/2] ACPI / button: Fix an issue that the platform triggered reliable events " Lv Zheng
2016-08-17 0:19 ` Rafael J. Wysocki
2016-08-17 4:45 ` Zheng, Lv
2016-07-26 9:52 ` [PATCH v7 2/2] ACPI / button: Add document for ACPI control method lid device restrictions Lv Zheng
2016-08-17 8:22 ` [PATCH v8 1/2] ACPI / button: Fix an issue in button.lid_init_state=ignore mode Lv Zheng
2016-09-12 22:10 ` Rafael J. Wysocki
2016-08-17 8:23 ` [PATCH v8 2/2] ACPI / button: Add document for ACPI control method lid device restrictions Lv Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1AE640813FDE7649BE1B193DEA596E883BBB71A8@SHSMSX101.ccr.corp.intel.com \
--to=lv.zheng@intel.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=benjamin.tissoires@gmail.com \
--cc=hadess@hadess.net \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).