From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751179AbcGLHIP (ORCPT ); Tue, 12 Jul 2016 03:08:15 -0400 Received: from mga09.intel.com ([134.134.136.24]:26424 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbcGLHIM (ORCPT ); Tue, 12 Jul 2016 03:08:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,350,1464678000"; d="scan'208";a="844632273" From: "Zheng, Lv" To: Bastien Nocera , Benjamin Tissoires CC: "Wysocki, Rafael J" , "Rafael J. Wysocki" , "Brown, Len" , Lv Zheng , "linux-kernel@vger.kernel.org" , ACPI Devel Maling List , linux-input , Dmitry Torokhov Subject: RE: [PATCH v2 4/4] ACPI / button: Add document for ACPI control method lid device restrictions Thread-Topic: [PATCH v2 4/4] ACPI / button: Add document for ACPI control method lid device restrictions Thread-Index: AQHR2B7y+AgHsCraR0Gb3MzkbQGo+KANvMuAgATXRrD///vzgIAB1xkw Date: Tue, 12 Jul 2016 07:06:00 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E883BC02868@SHSMSX101.ccr.corp.intel.com> References: <3f24a00df89f06661a64af6b4679a99bfff09aa7.1467875143.git.lv.zheng@intel.com> <1AE640813FDE7649BE1B193DEA596E883BC02198@SHSMSX101.ccr.corp.intel.com> <1468234721.2277.35.camel@hadess.net> In-Reply-To: <1468234721.2277.35.camel@hadess.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjQ5NTQwZjktOWIyNy00M2VjLWE0ZDktM2IwMGFhMjgyNTRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFUSXJ5eDZaQmZpQlc2OEtsRDVHQ3hhNml5ejh2cXlVMHBDaVZxTFl4R3c9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u6C78PtS025568 Hi, > From: Bastien Nocera [mailto:hadess@hadess.net] > Subject: Re: [PATCH v2 4/4] ACPI / button: Add document for ACPI control > method lid device restrictions > > On Mon, 2016-07-11 at 03:20 +0000, Zheng, Lv wrote: > > > > > > This worries me as there is no plan after "During the period the > > > userspace hasn't been switched to use the new event". > > > > > > I really hope you'll keep sending SW_LID for reliable LID > > > platforms, > > > and not remove it entirely as you will break platforms. > > > > [Lv Zheng] > > We won't remove SW_LID from the kernel :). > > > > And we haven't removed SW_LID from the acpi button driver. > > We'll just stop sending "initial lid state" from acpi button driver, > > i.e., the behavior carried out by "button.lid_init_state=ignore". > > > > Maybe it is not sufficient, after the userspace has been changed to > > support the new event, we should stop sending SW_LID from acpi button > > driver. > > For the affected devices? Sure, but I don't think that's a reasonable > thing to do for "all" the devices. We have a majority of laptops where > this isn't a problem, and it's not even a problem any more on one of > the devices that triggered this discussion (there's a patch for make > the LID status match reality for the Surface 3). [Lv Zheng] It looks, even with this fixed, there are tables never generating "lid open" event. Thus the lid notification is definitely not a "switch event". Thanks and best regards -Lv