From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287AbcGRKej (ORCPT ); Mon, 18 Jul 2016 06:34:39 -0400 Received: from mga14.intel.com ([192.55.52.115]:16364 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbcGRKed (ORCPT ); Mon, 18 Jul 2016 06:34:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,383,1464678000"; d="scan'208";a="1023842544" From: "Zheng, Lv" To: "Rafael J. Wysocki" CC: "Wysocki, Rafael J" , "Brown, Len" , Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Subject: RE: [UPDATE PATCH v2 1/3] ACPICA: Events: Introduce acpi_mask_gpe() to implement GPE masking mechanism Thread-Topic: [UPDATE PATCH v2 1/3] ACPICA: Events: Introduce acpi_mask_gpe() to implement GPE masking mechanism Thread-Index: AQHR1fuh4S1EQMgeFk2tC7BkC5eAu6AZx08AgARLyuA= Date: Mon, 18 Jul 2016 10:34:27 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E883BC04B78@SHSMSX101.ccr.corp.intel.com> References: <29ae6c9cdef0aa91f3461707c65ebcdee0ff7142.1466662469.git.lv.zheng@intel.com> <3293670.WgkPNILEVA@vostro.rjw.lan> <2122687.2llPIh43ST@vostro.rjw.lan> In-Reply-To: <2122687.2llPIh43ST@vostro.rjw.lan> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGU2OTU5YzQtYjdmMC00ZjBhLTgwNTAtMzBjOTVlYWRiOGQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlRHdDZcL1pMZjNnMUE0SHNKOGZXYWI5bDRjOHhnNjZOQ3lBdjZWeDZvMG9RPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u6IAYjXP008094 Hi, Rafael > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Subject: Re: [UPDATE PATCH v2 1/3] ACPICA: Events: Introduce > acpi_mask_gpe() to implement GPE masking mechanism > > On Monday, July 04, 2016 03:59:07 PM Rafael J. Wysocki wrote: > > On Thursday, June 23, 2016 03:05:47 PM Lv Zheng wrote: > > > (remove acpi_unmask_gpe() from the patch description) > > > > > > There is a facility in Linux, developers can control the > enabling/disabling > > > of a GPE via /sys/firmware/acpi/interrupts/gpexx. This is mainly for > > > debugging purposes. > > > > > > But many users expect to use this facility to implement quirks to mask > a > > > specific GPE when there is a gap in Linux causing this GPE to flood. This > > > is not working correctly because currently this facility invokes > > > enabling/disabling counting based GPE driver APIs: > > > acpi_enable_gpe()/acpi_disable_gpe() > > > and the GPE drivers can still affect the count to mess up the GPE > > > masking purposes. > > > > > > However, most of the IRQ chip designs allow masking/unmasking IRQs > via a > > > masking bit which is different from the enabled bit to achieve the same > > > purpose. But the GPE hardware doesn't contain such a feature, this > brings > > > the trouble. > > > > > > In this patch, we introduce a software mechanism to implement the > GPE > > > masking feature, and acpi_mask_gpe() are provided to the OSPMs to > > > mask/unmask GPEs in the above mentioned situation instead of > > > acpi_enable_gpe()/acpi_disable_gpe(). ACPICA BZ 1102. Lv Zheng. > > > > > > Link: https://bugs.acpica.org/show_bug.cgi?id=1102 > > > Signed-off-by: Lv Zheng > > > > I've queued up this one and the [2/3] and please see my comments on > the [3/3]. > > I've decided that it's better if this goes in via upstream ACPICA, so it's not > in the queue any more. > > For the time being, I'd like all changes in the ACPICA code to go in via the > upstream. [Lv Zheng] OK. Unlike several others, this is not an urgent feature or a feature that ACPICA upstream doesn't have environment to test. So we needn't to make in the upstream Linux first. Thanks and best regards -Lv