From: "Zheng, Lv" <lv.zheng@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
Cc: "Seetharaman, Anush" <anush.seetharaman@intel.com>,
"Kasanicky, Tiffany J" <tiffany.j.kasanicky@intel.com>,
"Jensen, Ryon" <ryon.jensen@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Jacque, Kristin" <kristin.jacque@intel.com>,
"Zhang, Rui" <rui.zhang@intel.com>
Subject: RE: [PATCH] acpi: fix acpi_get_table() leak / acpi-sysfs denial of service
Date: Wed, 26 Apr 2017 01:37:52 +0000 [thread overview]
Message-ID: <1AE640813FDE7649BE1B193DEA596E886CE98A4C@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <149314916034.8899.7439820192725219189.stgit@dwillia2-desk3.amr.corp.intel.com>
Hi,
> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Dan
> Williams
> Subject: [PATCH] acpi: fix acpi_get_table() leak / acpi-sysfs denial of service
>
> Reading an ACPI table through the /sys/firmware/acpi/tables interface
> more than 65,536 times leads to the following log message:
>
> ACPI Error: Table ffff88033595eaa8, Validation count is zero after increment
> (20170119/tbutils-423)
>
> ...and the table being unavailable until the next reboot. Add the
> missing acpi_put_table() so the table ->validation_count is decremented
> after each read.
For now, should just return AE_OK instead of AE_LIMIT in acpi_tb_get_table().
Otherwise this fix will not be sufficient to fix all possible problem
Unless we can add acpi_put_table() for all acpi_get_table() invocation.
Let me send a patch for you to try.
Thanks and best regards
Lv
>
> Cc: <stable@vger.kernel.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Rafael Wysocki <rafael.j.wysocki@intel.com>
> Cc: Kristin Jacque <kristin.jacque@intel.com>
> Cc: Tiffany Kasanicky <tiffany.j.kasanicky@intel.com>
> Cc: Ryon Jensen <ryon.jensen@intel.com>
> Reported-by: Anush Seetharaman <anush.seetharaman@intel.com>
> Fixes: 1c8fce27e275 ("ACPI: introduce drivers/acpi/sysfs.c")
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/acpi/sysfs.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
> index cf05ae973381..531ddabf0390 100644
> --- a/drivers/acpi/sysfs.c
> +++ b/drivers/acpi/sysfs.c
> @@ -333,14 +333,17 @@ static ssize_t acpi_table_show(struct file *filp, struct kobject *kobj,
> container_of(bin_attr, struct acpi_table_attr, attr);
> struct acpi_table_header *table_header = NULL;
> acpi_status status;
> + ssize_t rc;
>
> status = acpi_get_table(table_attr->name, table_attr->instance,
> &table_header);
> if (ACPI_FAILURE(status))
> return -ENODEV;
>
> - return memory_read_from_buffer(buf, count, &offset,
> - table_header, table_header->length);
> + rc = memory_read_from_buffer(buf, count, &offset, table_header,
> + table_header->length);
> + acpi_put_table(table);
> + return rc;
> }
>
> static int acpi_table_attr_init(struct kobject *tables_obj,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-26 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 19:39 [PATCH] acpi: fix acpi_get_table() leak / acpi-sysfs denial of service Dan Williams
2017-04-26 1:37 ` Zheng, Lv [this message]
2017-04-26 19:19 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1AE640813FDE7649BE1B193DEA596E886CE98A4C@SHSMSX101.ccr.corp.intel.com \
--to=lv.zheng@intel.com \
--cc=anush.seetharaman@intel.com \
--cc=dan.j.williams@intel.com \
--cc=kristin.jacque@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=ryon.jensen@intel.com \
--cc=stable@vger.kernel.org \
--cc=tiffany.j.kasanicky@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).