From: "Hebbar, Gururaja" <gururaja.hebbar@ti.com>
To: "S, Venkatraman" <svenkatr@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"cjb@laptop.org" <cjb@laptop.org>,
"Nori, Sekhar" <nsekhar@ti.com>,
"Rajashekhara, Sudhakar" <sudhakar.raj@ti.com>,
"Bedia, Vaibhav" <vaibhav.bedia@ti.com>
Subject: RE: [PATCH] mmc: omap_hsmmc: Pass on the suspend failure to the PM core
Date: Thu, 13 Sep 2012 07:09:41 +0000 [thread overview]
Message-ID: <1BAFE6F6C881BF42822005164F1491C33EA81214@DBDE01.ent.ti.com> (raw)
In-Reply-To: <CANfBPZ93ONzeYj=kD_7pbq=VBQLd98YM9BE9S+sPb3rrrXNFzQ@mail.gmail.com>
On Tue, Sep 11, 2012 at 11:13:26, S, Venkatraman wrote:
> On Tue, Sep 4, 2012 at 6:38 PM, Hebbar, Gururaja <gururaja.hebbar@ti.com> wrote:
> > From: Vaibhav Bedia <vaibhav.bedia@ti.com>
> >
> > In some cases mmc_suspend_host() is not able to claim the
> > host and proceed with the suspend process. The core returns
> > -EBUSY to the host controller driver. Unfortunately, the
> > host controller driver does not pass on this information
> > to the PM core and hence the system suspend process continues.
> >
> > In these cases the MMC core gets to an unexpected state
> > during resume and multiple issues related to MMC crop up.
> > 1. Host controller driver starts accessing the device registers
> > before the clocks are enabled which leads to a prefetch abort.
> > 2. A file copy thread which was launched before suspend gets
> > stuck due to the host not being reclaimed during resume.
> >
> > To avoid such problems pass on the -EBUSY status to the PM core
> > from the host controller driver. With this change, MMC core
> > suspend might still fail but it does not end up making the
> > system unusable. Suspend gets aborted and the user can try
> > suspending the system again.
> >
>
> The last time we discussed this, didn't we plan to fix this differently ?
> Holding the return code of mmc_suspend_host in a separate variable and
> passing it to the caller
> of omap_hsmmc_suspend looks more sane to me.
I just pushed a new revision (V2) with above changes. I also added extra information
(explanation with code snippet). Kindly let me know your review for the same.
>
Regards,
Gururaja
prev parent reply other threads:[~2012-09-13 7:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 13:08 [PATCH] mmc: omap_hsmmc: Pass on the suspend failure to the PM core Hebbar, Gururaja
2012-09-11 5:43 ` S, Venkatraman
2012-09-12 7:48 ` Hebbar, Gururaja
2012-09-13 7:09 ` Hebbar, Gururaja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1BAFE6F6C881BF42822005164F1491C33EA81214@DBDE01.ent.ti.com \
--to=gururaja.hebbar@ti.com \
--cc=cjb@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rob.herring@calxeda.com \
--cc=sudhakar.raj@ti.com \
--cc=svenkatr@ti.com \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).