From: Paul Cercueil <paul@crapouillou.net>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org, od@zcrc.me,
dri-devel@lists.freedesktop.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 2/3] drm/ingenic: Register devm action to cleanup encoders
Date: Mon, 18 Jan 2021 11:37:49 +0000 [thread overview]
Message-ID: <1BO4NQ.1RZAXLMVC01T@crapouillou.net> (raw)
In-Reply-To: <YAVYUzR9+ic5lEjE@pendragon.ideasonboard.com>
Hi Laurent,
Le lun. 18 janv. 2021 à 11:43, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> a écrit :
> Hi Paul,
>
> Thank you for the patch.
>
> On Sun, Jan 17, 2021 at 11:26:45AM +0000, Paul Cercueil wrote:
>> Since the encoders have been devm-allocated, they will be freed way
>> before drm_mode_config_cleanup() is called. To avoid use-after-free
>> conditions, we then must ensure that drm_encoder_cleanup() is called
>> before the encoders are freed.
>
> How about allocating the encoder with drmm_encoder_alloc() instead ?
That would work, but it is not yet in drm-misc-fixes :(
-Paul
>> Fixes: c369cb27c267 ("drm/ingenic: Support multiple panels/bridges")
>> Cc: <stable@vger.kernel.org> # 5.8+
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>> b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>> index 368bfef8b340..d23a3292a0e0 100644
>> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
>> @@ -803,6 +803,11 @@ static void __maybe_unused
>> ingenic_drm_release_rmem(void *d)
>> of_reserved_mem_device_release(d);
>> }
>>
>> +static void ingenic_drm_encoder_cleanup(void *encoder)
>> +{
>> + drm_encoder_cleanup(encoder);
>> +}
>> +
>> static int ingenic_drm_bind(struct device *dev, bool
>> has_components)
>> {
>> struct platform_device *pdev = to_platform_device(dev);
>> @@ -1011,6 +1016,11 @@ static int ingenic_drm_bind(struct device
>> *dev, bool has_components)
>> return ret;
>> }
>>
>> + ret = devm_add_action_or_reset(dev, ingenic_drm_encoder_cleanup,
>> + encoder);
>> + if (ret)
>> + return ret;
>> +
>> ret = drm_bridge_attach(encoder, bridge, NULL, 0);
>> if (ret) {
>> dev_err(dev, "Unable to attach bridge\n");
>
> --
> Regards,
>
> Laurent Pinchart
next prev parent reply other threads:[~2021-01-18 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 11:26 [PATCH 0/3] Fixes to bridge/panel and ingenic-drm Paul Cercueil
2021-01-17 11:26 ` [PATCH 1/3] drm: bridge/panel: Cleanup connector on bridge detach Paul Cercueil
2021-01-18 9:43 ` Laurent Pinchart
2021-01-17 11:26 ` [PATCH 2/3] drm/ingenic: Register devm action to cleanup encoders Paul Cercueil
2021-01-18 9:43 ` Laurent Pinchart
2021-01-18 11:37 ` Paul Cercueil [this message]
2021-01-18 12:52 ` Daniel Vetter
2021-01-17 11:26 ` [PATCH 3/3] drm/ingenic: Fix non-OSD mode Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1BO4NQ.1RZAXLMVC01T@crapouillou.net \
--to=paul@crapouillou.net \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=sam@ravnborg.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).