From: Liran Alon <liran.alon@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jmattson@google.com
Subject: Re: [PATCH] KVM: VMX: enable nested virtualization by default
Date: Wed, 17 Oct 2018 02:13:15 +0300 [thread overview]
Message-ID: <1CB58AE6-8057-4D76-8EA5-C219326F3432@oracle.com> (raw)
In-Reply-To: <20181016225522.13077-1-pbonzini@redhat.com>
> On 17 Oct 2018, at 1:55, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> With live migration support and finally a good solution for CR2/DR6
> exception payloads, nested VMX should finally be ready for having a stable
And good solution for setting/getting vCPU events from userspace with correct pending/injected state.
> userspace ABI. The results of syzkaller fuzzing are not perfect but not
> horrible either (and might be partially due to running on GCE, so that
> effectively we're testing three-level nesting on a fork of upstream KVM!).
> Enabling it by default seems like a nice way to conclude the 4.20
> pull request. :)
>
> Unfortunately, enabling nested SVM in 2009 was a bit premature. However,
Don’t you wish to mention commit which enabled it?
> until live migration support is in place we can reasonably expect that
> it does not offer much in terms of ABI guarantees. Therefore we are
> still in time to break things and conform as much as possible to the
> interface used for VMX.
>
> Suggested-by: Jim Mattson <jmattson@google.com>
> Suggested-by: Liran Alon <liran.alon@oracle.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> arch/x86/kvm/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index e665aa7167cf..89fc2a744d7f 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -107,7 +107,7 @@ module_param_named(enable_shadow_vmcs, enable_shadow_vmcs, bool, S_IRUGO);
> * VMX and be a hypervisor for its own guests. If nested=0, guests may not
> * use VMX instructions.
> */
> -static bool __read_mostly nested = 0;
> +static bool __read_mostly nested = 1;
> module_param(nested, bool, S_IRUGO);
>
> static u64 __read_mostly host_xss;
> --
> 2.17.1
>
Woohoo! :)
Reviewed-by: Liran Alon <liran.alon@oracle.com>
next prev parent reply other threads:[~2018-10-16 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 22:55 [PATCH] KVM: VMX: enable nested virtualization by default Paolo Bonzini
2018-10-16 23:13 ` Liran Alon [this message]
2018-10-17 0:44 ` Wanpeng Li
2018-10-17 8:21 ` Wincy Van
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1CB58AE6-8057-4D76-8EA5-C219326F3432@oracle.com \
--to=liran.alon@oracle.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).