From: Marcel Holtmann <marcel@holtmann.org>
To: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:BLUETOOTH SUBSYSTEM" <linux-bluetooth@vger.kernel.org>,
Hemantg <hemantg@codeaurora.org>,
MSM <linux-arm-msm@vger.kernel.org>,
pharish@codeaurora.org, Rocky Liao <rjliao@codeaurora.org>,
hbandi@codeaurora.org, abhishekpandit@chromium.org,
mcchou@chromium.org
Subject: Re: [PATCH] Bluetooth: hci_qca: Set SSR triggered flags when SSR command is sent out
Date: Mon, 16 Aug 2021 18:07:43 +0200 [thread overview]
Message-ID: <1CE27E9C-EABD-4B25-B255-8925297D11BD@holtmann.org> (raw)
In-Reply-To: <1629091302-7893-1-git-send-email-bgodavar@codeaurora.org>
Hi Balakrishna,
> This change sets SSR triggered flags when QCA SSR command is sent to
> SoC. After the SSR command sent, driver discards the incoming data from
> the upper layers. This way will ensure to read full dumps from the
> BT SoC without any flow control issues due to excess of data receiving
> from the HOST in audio usecases.
>
> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> ---
> drivers/bluetooth/hci_qca.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 53deea2..5cbed6a 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -69,6 +69,8 @@
> #define QCA_LAST_SEQUENCE_NUM 0xFFFF
> #define QCA_CRASHBYTE_PACKET_LEN 1096
> #define QCA_MEMDUMP_BYTE 0xFB
> +#define QCA_SSR_OPCODE 0xFC0C
> +#define QCA_SSR_PKT_LEN 5
>
> enum qca_flags {
> QCA_IBS_DISABLED,
> @@ -871,6 +873,14 @@ static int qca_enqueue(struct hci_uart *hu, struct sk_buff *skb)
> /* Prepend skb with frame type */
> memcpy(skb_push(skb, 1), &hci_skb_pkt_type(skb), 1);
>
> + if (hci_skb_pkt_type(skb) == HCI_COMMAND_PKT &&
> + skb->len == QCA_SSR_PKT_LEN &&
> + hci_skb_opcode(skb) == QCA_SSR_OPCODE) {
> + bt_dev_info(hu->hdev, "Triggering ssr");
> + set_bit(QCA_SSR_TRIGGERED, &qca->flags);
> + set_bit(QCA_MEMDUMP_COLLECTION, &qca->flags);
> + }
> +
can we please stop hacking around by parsing opcodes in an enqueue function. Sounds like someone is injecting raw HCI vendor commands and then having a driver react to it.
Regards
Marcel
next prev parent reply other threads:[~2021-08-16 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 5:21 [PATCH] Bluetooth: hci_qca: Set SSR triggered flags when SSR command is sent out Balakrishna Godavarthi
2021-08-16 16:07 ` Marcel Holtmann [this message]
2021-08-17 11:20 ` bgodavar
2021-08-19 15:03 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1CE27E9C-EABD-4B25-B255-8925297D11BD@holtmann.org \
--to=marcel@holtmann.org \
--cc=abhishekpandit@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=hbandi@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcchou@chromium.org \
--cc=mka@chromium.org \
--cc=pharish@codeaurora.org \
--cc=rjliao@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).