From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C404C43334 for ; Wed, 5 Sep 2018 08:05:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5BC82064D for ; Wed, 5 Sep 2018 08:05:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5BC82064D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aosc.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727792AbeIEMeb convert rfc822-to-8bit (ORCPT ); Wed, 5 Sep 2018 08:34:31 -0400 Received: from hermes.aosc.io ([199.195.250.187]:57350 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbeIEMeb (ORCPT ); Wed, 5 Sep 2018 08:34:31 -0400 Received: from localhost (localhost [127.0.0.1]) (Authenticated sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id 714C0FFAF3; Wed, 5 Sep 2018 08:05:24 +0000 (UTC) Date: Wed, 05 Sep 2018 16:05:18 +0800 In-Reply-To: <20180905075601.32kzkd3is2gpa3ft@flea> References: <20180903133434.58188-1-icenowy@aosc.io> <20180903133434.58188-2-icenowy@aosc.io> <20180905071435.lgsogpzmh5nw6bcy@flea> <3D28A45F-D67D-4388-9FB7-2A2763955398@aosc.io> <20180905075601.32kzkd3is2gpa3ft@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH 1/3] dt-bindings: change the A64 HDMI PHY binding to R40 To: linux-arm-kernel@lists.infradead.org, Maxime Ripard CC: devicetree@vger.kernel.org, Jernej Skrabec , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, Chen-Yu Tsai From: Icenowy Zheng Message-ID: <1CE38B34-005F-4E49-B9B5-48EDFA56EFE5@aosc.io> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2018年9月5日 GMT+08:00 下午3:56:01, Maxime Ripard 写到: >On Wed, Sep 05, 2018 at 03:46:41PM +0800, Icenowy Zheng wrote: >> >> >> 于 2018年9月5日 GMT+08:00 下午3:14:35, Maxime Ripard > 写到: >> >On Mon, Sep 03, 2018 at 09:34:32PM +0800, Icenowy Zheng wrote: >> >> By experiment, the A64 HDMi PHY doesn't support the PLL-VIDEO mux >> >> introduced in R40, although it has two PLL-VIDEOs. >> >> >> >> Change the A64 HDMI PHY binding to R40 one. >> >> >> >> This binding is introduced in v4.19, which is still in RC stage, >so >> >we >> >> have change to fix it. >> >> >> >> Signed-off-by: Icenowy Zheng >> > >> >That doesn't make much sense. The A64 doesn't have any particular >> >reason to behave like the R40, and the R40 can definitely use a >> >different compatible if it has a different behaviour. But I don't >see >> >*why* the A64 not behaving like the R40 is a justification to remove >> >the A64 compatible. Especially when the R40 was released later. >> > >> >Add a new compatible, and leave the A64 compatible alone. >> >> But the behavior of A64 compatible will change from double >> PLL to single PLL, because the A64 HDMI PHY is proven >> to have no double PLL. >> >> Should I then change the A64 compatible behavior and import R40 >> compatible at the same time? > >I don't see why you should do both at the same time. Fix the A64, and >add the support for the R40, those are two orthogonal changes. Then how to deal with double PLL support? Make them temporarily dead during 4.19? > >> In addition maybe I can just drop A64 compatible, and let A64 >> use H3 one. > >No, that break the backward compatibility. As I said A64 compatible is just introduced in 4.19-rc. So if we finish before 4.19.0 we break nothing. > >Maxime