archive mirror
 help / color / mirror / Atom feed
* Fix bug: Scheduler's idle-load-balancer not running in first 5 mins after bootup
@ 2012-01-30 18:14 Diwakar Tundlam
  2012-01-31  3:49 ` Mike Galbraith
  2012-01-31 15:52 ` Kamalesh Babulal
  0 siblings, 2 replies; 4+ messages in thread
From: Diwakar Tundlam @ 2012-01-30 18:14 UTC (permalink / raw)
  To: 'Ingo Molnar', 'Peter Zijlstra',
  Cc: Peter De Schrijver, Antti Miettinen, Matthew Longnecker, Kevin Kranzusch

We ran into this at Nvidia. QA filed a bug saying coremark_4pthreads scores lower (as if running on 3 cores) when run shortly after bootup. But later its score increases to expected values on 4 cores.

This patch is relevant to linux-2.6.39 but I noticed this fix is not made in linux-3.0, 3.1, 3.2 or 3.3 also.

Please see commit log for more details of the problem and fix.

  Tegra Android Kernel SW Engg.
  Santa Clara, CA

commit d04d7ef0e3f8c70bd6cd5abb2abc0236aa8d1f7c
Author: Diwakar Tundlam <>
Date:   Wed Jan 18 18:58:57 2012 -0800

    scheduler: domain: init next_balance in nohz_idle_balancer with jiffies
    The next_balance parameter of nohz_idle_balancer should be initialized
    to jiffies since jiffies itself is initialized to 300 seconds shy of
    overflow. Otherwise, nohz_idle_balancer does not run for the first 5
    mins after bootup.
    Signed-off-by: Diwakar Tundlam <>
    Reviewed-by: Aleksandr Frid <>
    Reviewed-by: Peter Boonstoppel <>
    Reviewed-by: Satya Popuri <>

 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c index c5b09f7..506c5da 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -8288,6 +8288,7 @@ void __init sched_init(void)
        atomic_set(&nohz.load_balancer, nr_cpu_ids);
        atomic_set(&nohz.first_pick_cpu, nr_cpu_ids);
        atomic_set(&nohz.second_pick_cpu, nr_cpu_ids);
+       nohz.next_balance = jiffies;
        /* May be allocated at isolcpus cmdline parse time */
        if (cpu_isolated_map == NULL)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-01-31 19:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-30 18:14 Fix bug: Scheduler's idle-load-balancer not running in first 5 mins after bootup Diwakar Tundlam
2012-01-31  3:49 ` Mike Galbraith
2012-01-31 19:15   ` Diwakar Tundlam
2012-01-31 15:52 ` Kamalesh Babulal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).