From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F36C4320A for ; Fri, 20 Aug 2021 21:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F73E6108B for ; Fri, 20 Aug 2021 21:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240775AbhHTVbC (ORCPT ); Fri, 20 Aug 2021 17:31:02 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:49999 "EHLO wout4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231761AbhHTVbB (ORCPT ); Fri, 20 Aug 2021 17:31:01 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4146A3200933; Fri, 20 Aug 2021 17:30:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 20 Aug 2021 17:30:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=U5X+tI 73SRv3hWvY6y5Sg5KMMobaVA4WYF5XYgKBPIc=; b=GLzNIOM/ezHv7mTy4UJ+gC LkEexKc/PcfAfbzhfSlVWSoWC5jnI+BTnbpDARKxrSbIqB2oWgLXKjgfUw3Jzhd3 aglevuoWnA6FXDv1xEAE0brHXthW32X825umIzZsxAJqlP9CT+G7YQxeoE9Nl6qI V65JXbupifmlmA9qLteS2GGDCIZKGaqs+3tY/K4dfBOXfToGFZhEV8zLXEPVJLEq zd085eFd+AetqkbCwEJSEza3tg3yussUWxycbRPYRc1kmA0QMxBesGPhrpXithCN 2lCmDEp/hfQAORMEmXKwy2h9XzzjZkjb0i52jjWmnvE17cjSIpA3GbkUToCrrg7Q == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrleelgdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffuvffkjghfofggtgesthdtre dtredtvdenucfhrhhomhepnfhukhgvucflohhnvghsuceolhhukhgvsehljhhonhgvshdr uggvvheqnecuggftrfgrthhtvghrnhepgfeffedufffhgfeuheegffffgeegveeifeeute fhieejffetudfgueevteehtdetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Aug 2021 17:30:16 -0400 (EDT) Date: Sat, 21 Aug 2021 09:30:00 +1200 From: Luke Jones Subject: Re: [PATCH v4 1/1] asus-wmi: Add support for custom fan curves To: Bastien Nocera Cc: linux-kernel@vger.kernel.org, hdegoede@redhat.com, platform-driver-x86@vger.kernel.org Message-Id: <1EQ5YQ.6O8MNIPTU6V4@ljones.dev> In-Reply-To: References: <20210820095726.14131-1-luke@ljones.dev> <20210820095726.14131-2-luke@ljones.dev> <321afe1a293be3a623a9be53feea3a008e044b31.camel@hadess.net> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 20 2021 at 13:39:02 +0200, Bastien Nocera wrote: > On Fri, 2021-08-20 at 23:00 +1200, Luke Jones wrote: >> >> >> On Fri, Aug 20 2021 at 12:51:08 +0200, Bastien Nocera >> wrote: >> > On Fri, 2021-08-20 at 12:43 +0200, Bastien Nocera wrote: >> > > On Fri, 2021-08-20 at 22:33 +1200, Luke Jones wrote: >> > > > > Am I going to get bug reports from Asus users that will >> > > complain >> > > > > that >> > > > > power-profiles-daemon doesn't work correctly, where I will >> > > have >> > > > > to >> > > > > wearily ask if they're using an Asus Rog laptop? >> > > > >> > > > No. Definitely not. The changes to fan curves per-profile >> need >> > > to >> > > > be >> > > > explicitly enabled and set. So a new user will be unaware >> that >> > > this >> > > > control exists (until they look for it) and their laptop will >> > > > behave >> > > > exactly as default. >> > > >> > > "The user will need to change the fan curves manually so will >> > > definitely remember to mention it in bug reports" is a very >> > > different >> > > thing to "the user can't change the fan curves to be >> nonsensical >> > > and >> > > mean opposite things". >> > > >> > > I can assure you that I will eventually get bug reports from >> > > "power >> > > users" who break their setup and wonder why things don't work >> > > properly, >> > > without ever mentioning the changes they made changes to the >> fan >> > > curves, or anything else they might have changed. >> > >> > A way to taint the settings that power-profiles-daemon could catch >> > would be fine by me. I absolutely don't want to have to support >> > somebody's tweaks until they undo them. >> >> Definitely understood. Do you have something in mind? > > A sysfs attribute with boolean data that shows whether custom fan > curves are used would be enough. The path /sys/devices/platform/asus-nb-wmi/active_fan_curve_profiles should be usable like this? I added this as the method for controlling which fan curves for which profiles are active. If empty, then no custom fan curves are active at all. If it contains any combination of strings "quiet, balanced, performance" then those associated (named) platform_profiles have an active fan curve and you can throw up a general warning, maybe add the contents of that file too? > > I could then check whether that file exists on startup, and throw a > warning if custom curves are used, or become used, so that it shows up > in power-profiles-daemon's logs. >