From: "Tirdea, Irina" <irina.tirdea@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Bastien Nocera <hadess@hadess.net>,
Aleksei Mamlin <mamlinav@gmail.com>,
Karsten Merker <merker@debian.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Purdila, Octavian" <octavian.purdila@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v11 3/8] Input: goodix - write configuration data to device
Date: Fri, 20 Nov 2015 13:13:03 +0000 [thread overview]
Message-ID: <1F3AC3675D538145B1661F571FE1805F2F12029F@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20151119182038.GA24773@dtor-ws>
> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> Sent: 19 November, 2015 20:21
> To: Tirdea, Irina
> Cc: Bastien Nocera; Aleksei Mamlin; Karsten Merker; linux-input@vger.kernel.org; Mark Rutland; Rob Herring; Purdila, Octavian; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v11 3/8] Input: goodix - write configuration data to device
>
> On Thu, Nov 19, 2015 at 02:26:36PM +0200, Irina Tirdea wrote:
> > + if (ts->gpiod_int && ts->gpiod_rst) {
> > + /* update device config */
> > + ts->cfg_name = kasprintf(GFP_KERNEL, "goodix_%d_cfg.bin",
> > + ts->id);
>
> devm_kasprintf maybe (don't resubmit)?
>
Yes, using devm_kasprintf would be better.
Thanks,
Irina
> Thanks.
>
> --
> Dmitry
next prev parent reply other threads:[~2015-11-20 13:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 12:26 [PATCH v11 0/8] Goodix touchscreen enhancements Irina Tirdea
2015-11-19 12:26 ` [PATCH v11 1/8] Input: goodix - use actual config length for each device type Irina Tirdea
2015-11-19 12:26 ` [PATCH v11 2/8] Input: goodix - reset device at init Irina Tirdea
2015-11-19 15:25 ` Bastien Nocera
2015-11-19 15:36 ` Tirdea, Irina
2015-11-20 15:41 ` Rob Herring
2015-11-23 16:31 ` Bastien Nocera
2015-12-08 12:04 ` Aleksei Mamlin
2015-11-19 12:26 ` [PATCH v11 3/8] Input: goodix - write configuration data to device Irina Tirdea
2015-11-19 18:20 ` Dmitry Torokhov
2015-11-20 13:13 ` Tirdea, Irina [this message]
2015-11-23 16:32 ` Bastien Nocera
2015-12-08 12:09 ` Aleksei Mamlin
2015-11-19 12:26 ` [PATCH v11 4/8] Input: goodix - add power management support Irina Tirdea
2015-11-19 18:24 ` Dmitry Torokhov
2015-11-19 22:18 ` Rafael J. Wysocki
2015-11-19 22:31 ` Dmitry Torokhov
2015-11-23 16:33 ` Bastien Nocera
2015-11-19 12:26 ` [PATCH v11 5/8] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send Irina Tirdea
2015-11-19 12:26 ` [PATCH v11 6/8] Input: goodix - add support for ESD Irina Tirdea
2015-11-20 15:44 ` Rob Herring
2015-11-20 17:20 ` Dmitry Torokhov
2015-11-27 17:24 ` Tirdea, Irina
2015-11-27 17:28 ` Dmitry Torokhov
2015-11-23 16:33 ` Bastien Nocera
2015-11-19 12:26 ` [PATCH v11 7/8] Input: goodix - add sysfs interface to dump config Irina Tirdea
2015-11-19 12:26 ` [PATCH v11 8/8] Input: goodix - add runtime power management support Irina Tirdea
2015-11-23 16:35 ` Bastien Nocera
2015-12-18 1:13 ` [PATCH v11 0/8] Goodix touchscreen enhancements Dmitry Torokhov
2016-01-05 20:03 ` Karsten Merker
2016-01-05 22:07 ` Dmitry Torokhov
2016-01-06 7:00 ` Karsten Merker
2016-01-06 19:08 ` Karsten Merker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1F3AC3675D538145B1661F571FE1805F2F12029F@irsmsx105.ger.corp.intel.com \
--to=irina.tirdea@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mamlinav@gmail.com \
--cc=mark.rutland@arm.com \
--cc=merker@debian.org \
--cc=octavian.purdila@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).