From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936214AbcJ0Nuv convert rfc822-to-8bit (ORCPT ); Thu, 27 Oct 2016 09:50:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:35091 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935913AbcJ0Nuq (ORCPT ); Thu, 27 Oct 2016 09:50:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,404,1473145200"; d="scan'208";a="24315855" From: "Tirdea, Irina" To: Darren Hart , Thomas Gleixner CC: "linux-clk@vger.kernel.org" , "x86@kernel.org" , Stephen Boyd , Ingo Molnar , Michael Turquette , "H. Peter Anvin" , "alsa-devel@alsa-project.org" , Mark Brown , Takashi Iwai , "Bossart, Pierre-louis" , LKML , Pierre-Louis Bossart Subject: RE: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks Thread-Topic: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks Thread-Index: AQHSKLNcj/RD2Y73bkyhe2Anfh6OTaCx1mEAgAB3RgCABVNGwIADnhCAgAACzQCAAAVAAIABGLnA Date: Thu, 27 Oct 2016 13:50:02 +0000 Deferred-Delivery: Thu, 27 Oct 2016 13:49:00 +0000 Message-ID: <1F3AC3675D538145B1661F571FE1805F2F38B3E2@irsmsx105.ger.corp.intel.com> References: <1476735320-4315-1-git-send-email-irina.tirdea@intel.com> <20161021045932.GA90338@f23x64.localdomain> <1F3AC3675D538145B1661F571FE1805F2F387575@irsmsx105.ger.corp.intel.com> <20161026213323.GB23374@f23x64.localdomain> <20161026220212.GA24422@f23x64.localdomain> In-Reply-To: <20161026220212.GA24422@f23x64.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzE4ZTQ2NjAtZDczMC00YTQzLTlmY2QtN2ZkMTAxNDA3MzI5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRwdTNNSUJCTVpSMTlteDBXdTNSeHpwbFB4UHMwak1jU1Q3Y0hCSGs1SHc9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Darren Hart wrote: > On Wed, Oct 26, 2016 at 11:43:24PM +0200, Thomas Gleixner wrote: > > On Wed, 26 Oct 2016, Darren Hart wrote: > > > On Mon, Oct 24, 2016 at 01:38:54PM +0000, Tirdea, Irina wrote: > > > > intel_pmc_* drivers or is it enough to move it as a standalone > > > > driver for now? > > > > > > If the functionality is substantially different, then I don't see a > > > compelling, and certainly not an immediate, need to merge them. > > > Assume for now they are to remain as separate drivers. I suggest > > > keeping the existing name for now as well. Let's just complete the > > > move with as little user-visible changes as possible. > > > > > > The placement of the header file is a bit tricky as it is being used > > > in drivers/clk/x86 in addition to the pmc_atom driver in > > > drivers/platform/x86. > > > > > > The best existing location would appear to be include/platform_data/ > > > > > > Thomas, is that acceptable to you? > > > > Yes > > > > > arch/x86/platform/atom/pmc_atom.c -> drivers/platform/x86 > > > arch/x86/include/asm/pmc_atom.h -> include/platform_data/ > > > > > > If there are enough of these, it might make sense to create: > > > > > > include/platform/x86/ > > > > > > but I suggest we start with minimal change. > > > > No. Make that x86 directory right away. include/platform_data is > > already a maze of 224 files. Start structuring it now. > > OK, that's fine with me too. > > (but I typo'd, should have been: include/linux/platform_data/x86) > > Irina, does this give you enough to go on? > Yes, everything is clear now. I will make the change and send a patch in a few days. Thanks, Irina