From: Haiyang Zhang <haiyangz@microsoft.com>
To: Joe Perches <joe@perches.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'devel@driverdev.osuosl.org'" <devel@driverdev.osuosl.org>,
"'virtualization@lists.osdl.org'" <virtualization@lists.osdl.org>,
"'gregkh@suse.de'" <gregkh@suse.de>,
Hank Janssen <hjanssen@microsoft.com>
Subject: RE: [PATCH 1/1] Rename camel case variables in channel.c
Date: Thu, 23 Sep 2010 21:04:02 +0000 [thread overview]
Message-ID: <1FB5E1D5CA062146B38059374562DF7289ED3968@TK5EX14MBXC130.redmond.corp.microsoft.com> (raw)
In-Reply-To: <1285274468.25928.15.camel@Joe-Laptop>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 851 bytes --]
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Thursday, September 23, 2010 4:41 PM
> > - struct hv_monitor_page *monitorPage;
> > + struct hv_monitor_page *monitorpage;
>
> Some of these renames would be better with a "_" for
> the CamelCase conversions (ie: CamelCase -> camel_case).
Yes, for longer names I usually insert underscore. For example,
I changed packetLenAligned to packetlen_aligned.
> > + struct hv_monitor_page *monitorpage;
> > + u8 monitorGroup = (u8)channel->OfferMsg.MonitorId / 32;
> > + u8 monitorOffset = (u8)channel->OfferMsg.MonitorId % 32;
>
> Why not convert these to monitor_(group|offset)?
That's a good catch. I will update it.
Thanks,
- Haiyang
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
prev parent reply other threads:[~2010-09-23 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 20:24 [PATCH 1/1] Rename camel case variables in channel.c Haiyang Zhang
2010-09-23 20:41 ` Joe Perches
2010-09-23 21:04 ` Haiyang Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1FB5E1D5CA062146B38059374562DF7289ED3968@TK5EX14MBXC130.redmond.corp.microsoft.com \
--to=haiyangz@microsoft.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=hjanssen@microsoft.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).