From: Marcel Holtmann <marcel@holtmann.org>
To: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
mka@chromium.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download
Date: Sun, 30 Dec 2018 09:10:45 +0100 [thread overview]
Message-ID: <1FC4CC11-B070-4ACF-9107-857A4D392876@holtmann.org> (raw)
In-Reply-To: <de93a7b7169a0cfb8f28f5d8e5138dc7@codeaurora.org>
Hi Balakrishna,
>>> Latest qualcomm chips are not sending an command complete event for
>>> every firmware packet sent to chip. They only respond with a vendor
>>> specific event for the last firmware packet. This optimization will
>>> decrease the BT ON time. Due to this we are seeing a timeout error
>>> message logs on the console during firmware download. Now we are
>>> injecting a command complete event once we receive an vendor specific
>>> event for the last RAM firmware packet.
>>> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>>> ---
>>> drivers/bluetooth/btqca.c | 39 ++++++++++++++++++++++++++++++++++++++-
>>> drivers/bluetooth/btqca.h | 3 +++
>>> 2 files changed, 41 insertions(+), 1 deletion(-)
>>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>>> index ec9e03a6b778..0b533f65f652 100644
>>> --- a/drivers/bluetooth/btqca.c
>>> +++ b/drivers/bluetooth/btqca.c
>>> @@ -144,6 +144,7 @@ static void qca_tlv_check_data(struct rome_config *config,
>>> * In case VSE is skipped, only the last segment is acked.
>>> */
>>> config->dnld_mode = tlv_patch->download_mode;
>>> + config->dnld_type = config->dnld_mode;
>>> BT_DBG("Total Length : %d bytes",
>>> le32_to_cpu(tlv_patch->total_size));
>>> @@ -264,6 +265,31 @@ static int qca_tlv_send_segment(struct hci_dev *hdev, int seg_size,
>>> return err;
>>> }
>>> +static int qca_inject_cmd_complete_event(struct hci_dev *hdev)
>>> +{
>>> + struct hci_event_hdr *hdr;
>>> + struct hci_ev_cmd_complete *evt;
>>> + struct sk_buff *skb;
>>> +
>>> + skb = bt_skb_alloc(sizeof(*hdr) + sizeof(*evt) + 1, GFP_KERNEL);
>>> + if (!skb)
>>> + return -ENOMEM;
>>> +
>>> + hdr = skb_put(skb, sizeof(*hdr));
>>> + hdr->evt = HCI_EV_CMD_COMPLETE;
>>> + hdr->plen = sizeof(*evt) + 1;
>>> +
>>> + evt = skb_put(skb, sizeof(*evt));
>>> + evt->ncmd = 1;
>>> + evt->opcode = HCI_OP_NOP;
>>> +
>>> + skb_put_u8(skb, QCA_HCI_CC_SUCCESS);
>>> +
>>> + hci_skb_pkt_type(skb) = HCI_EVENT_PKT;
>>> +
>>> + return hci_recv_frame(hdev, skb);
>>> +}
>>> +
>>> static int qca_download_firmware(struct hci_dev *hdev,
>>> struct rome_config *config)
>>> {
>>> @@ -297,11 +323,22 @@ static int qca_download_firmware(struct hci_dev *hdev,
>>> ret = qca_tlv_send_segment(hdev, segsize, segment,
>>> config->dnld_mode);
>>> if (ret)
>>> - break;
>>> + goto out;
>>> segment += segsize;
>>> }
>>> + /* Latest qualcomm chipsets are not sending a command complete event
>>> + * for every fw packet sent. They only respond with a vendor specific
>>> + * event for the last packet. This optimization in the chip will
>>> + * decrease the BT in initialization time. Here we will inject a command
>>> + * complete event to avoid a command timeout error message.
>>> + */
>>> + if ((config->dnld_type == ROME_SKIP_EVT_VSE_CC ||
>>> + config->dnld_type == ROME_SKIP_EVT_VSE))
>>> + return qca_inject_cmd_complete_event(hdev);
>>> +
>> have you actually considered using __hci_cmd_send in that case. It is
>> allowed for vendor OGF to use that command. I see you actually do use
>> it and now I am failing to understand what this is for.
> [Bala]: thanks for reviewing the change.
>
> __hci_cmd_send() can be used only to send the command to the chip. it will not wait for the response for the command sent.
>
> as you know that every vendor command sent to chip will respond with vendor specific event and command complete event.
> but in our case chip will only respond with vendor specific event only. so we are injecting command complete event.
and __hci_cmd_sync_ev is also not working for you? However since you are not waiting for the vendor event anyway and just injecting cmd_complete, I wonder what’s the difference in just using __hci_cmd_send and not bothering to wait or inject at all. I am failing to see where this injection makes a difference.
For me it is a big difference if we are injecting one event like in the case of Intel compared to injecting one for every command. It will show a wrong picture in btmon and that is a bad idea.
Regards
Marcel
next prev parent reply other threads:[~2018-12-30 8:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 11:48 [PATCH v7 0/4] Bug fixes for Qualcomm BT chip wcn3990 Balakrishna Godavarthi
2018-12-28 11:48 ` [PATCH v7 1/4] Bluetooth: hci_qca: use wait_until_sent() for power pulses Balakrishna Godavarthi
2018-12-28 17:20 ` Matthias Kaehlcke
2018-12-28 11:48 ` [PATCH v7 2/4] Bluetooth: hci_qca: Deassert RTS while baudrate change command Balakrishna Godavarthi
2018-12-28 11:48 ` [PATCH v7 3/4] Bluetooth: hci_qca: Disable IBS state machine and flush Tx buffer Balakrishna Godavarthi
2018-12-28 20:25 ` Matthias Kaehlcke
2018-12-28 11:48 ` [PATCH v7 4/4] Bluetooth: btqca: inject command complete event during fw download Balakrishna Godavarthi
2018-12-28 19:50 ` Matthias Kaehlcke
2018-12-29 7:18 ` Marcel Holtmann
2018-12-29 7:45 ` Balakrishna Godavarthi
2018-12-30 8:10 ` Marcel Holtmann [this message]
2018-12-31 6:04 ` Balakrishna Godavarthi
2018-12-31 8:03 ` Balakrishna Godavarthi
2019-01-02 22:15 ` Matthias Kaehlcke
2019-01-10 15:00 ` Balakrishna Godavarthi
2019-01-10 20:43 ` Matthias Kaehlcke
2019-01-11 14:23 ` Balakrishna Godavarthi
2019-01-11 23:12 ` Matthias Kaehlcke
2019-01-14 15:51 ` Balakrishna Godavarthi
2019-01-15 1:20 ` Matthias Kaehlcke
2019-01-16 9:36 ` Balakrishna Godavarthi
2019-01-16 19:57 ` Matthias Kaehlcke
2019-01-17 10:19 ` Balakrishna Godavarthi
2019-01-18 8:57 ` Marcel Holtmann
2019-01-18 21:03 ` Matthias Kaehlcke
2019-02-08 21:05 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1FC4CC11-B070-4ACF-9107-857A4D392876@holtmann.org \
--to=marcel@holtmann.org \
--cc=bgodavar@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).