From: Rakesh Iyer <riyer@nvidia.com>
To: Shubhrajyoti <shubhrajyoti@ti.com>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
Stephen Warren <swarren@nvidia.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1] Input: tegra-kbc - enable key interrupt for wakeup
Date: Thu, 19 Jan 2012 10:21:43 -0800 [thread overview]
Message-ID: <1FC56210173BB445BD77F608D6FB8D034F401D296F@HQMAIL03.nvidia.com> (raw)
In-Reply-To: <4F17AE75.6000605@ti.com>
> if (device_may_wakeup(&pdev->dev)) {
> disable_irq_wake(kbc->irq);
> tegra_kbc_setup_wakekeys(kbc, false);
> + /* We will use fifo interrupts for key detection. */
> + tegra_kbc_set_keypress_interrupt(kbc, false);
Why do yo disable on resume why not have it enabled always?
>
> /* Restore the resident time of continuous polling mode. */
> writel(kbc->cp_to_wkup_dly, kbc->mmio + KBC_TO_CNT_0);
For the relevant discussion, Tegra KBC provides the following interrupts -
a) The keypress interrupt which is generated as soon as a key is pressed,
before matrix scanning begins.
b) FIFO interrupt which is generated when actual keys are decoded from the matrix,
and put into the FIFO.
During normal operation the keypress interrupt is not useful as we have to wait for the
keys to make it into the FIFO before reporting it to the higher layers.
Since we have turned off scanning(in the following commit) we cannot use the FIFO interrupt
during the resume, so we rely on the keypress interrupt and generate the wakeup key.
Commit that turned off scanning
Input: tegra-kbc - fix wakeup from suspend
For wakeup to be reliable, kbc needs to be in interrupt mode before suspend.
Created common routine to control the FIFO interrupt.
Added synchronization to ensure orderly suspend.
Regards
Rakesh
next prev parent reply other threads:[~2012-01-19 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 22:33 [PATCH v1] Input: tegra-kbc - enable key interrupt for wakeup Rakesh Iyer
2012-01-19 5:47 ` Shubhrajyoti
2012-01-19 18:21 ` Rakesh Iyer [this message]
2012-01-24 5:24 ` Datta, Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1FC56210173BB445BD77F608D6FB8D034F401D296F@HQMAIL03.nvidia.com \
--to=riyer@nvidia.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).