From: Paul Cercueil <paul@crapouillou.net>
To: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Christophe Branchereau <cbranchereau@gmail.com>,
od@zcrc.me, dri-devel <dri-devel@lists.freedesktop.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings
Date: Mon, 30 Nov 2020 19:39:01 +0000 [thread overview]
Message-ID: <1XJMKQ.YER47WG3D7R41@crapouillou.net> (raw)
In-Reply-To: <CAL_JsqLSGMFibm8tVKqNe1SFBzXTU2=M2jZmpfrHeGUqS3foRg@mail.gmail.com>
Hi Rob,
Le lun. 30 nov. 2020 à 7:32, Rob Herring <robh+dt@kernel.org> a écrit
:
> On Mon, Nov 2, 2020 at 3:19 AM Paul Cercueil <paul@crapouillou.net>
> wrote:
>>
>>
>>
>> Le dim. 1 nov. 2020 à 13:29, Sam Ravnborg <sam@ravnborg.org> a
>> écrit :
>> > On Sun, Nov 01, 2020 at 09:31:48AM +0000, Paul Cercueil wrote:
>> >> The Asia Better Technology (ABT) Y030XX067A panel is a 3.0"
>> 320x480
>> >> 24-bit IPS LCD panel. Its particularity is that it has
>> non-square
>> >> pixels
>> >> (as it is 4:3 for a resolution of 320x480), and that it
>> requires odd
>> >> lines to be sent as RGB and even lines to be sent as GRB on its
>> >> 8-bit
>> >> bus.
>> >>
>> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> >> ---
>> >> .../display/panel/abt,y030xx067a.yaml | 54
>> >> +++++++++++++++++++
>> >> 1 file changed, 54 insertions(+)
>> >> create mode 100644
>> >>
>> Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
>> >>
>> >> diff --git
>> >>
>> a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
>> >>
>> b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
>> >> new file mode 100644
>> >> index 000000000000..6407e8bf45fa
>> >> --- /dev/null
>> >> +++
>> >>
>> b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
>> >> @@ -0,0 +1,54 @@
>> >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> >> +%YAML 1.2
>> >> +---
>> >> +$id:
>> >> http://devicetree.org/schemas/display/panel/abt,y030xx067a.yaml#
>> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> >> +
>> >> +title: Asia Better Technology 3.0" (320x480 pixels) 24-bit IPS
>> LCD
>> >> panel
>> >> +
>> >> +description: |
>> >> + The panel must obey the rules for a SPI slave device as
>> >> specified in
>> >> + spi/spi-controller.yaml
>> >> +
>> >> +maintainers:
>> >> + - Paul Cercueil <paul@crapouillou.net>
>> >> +
>> >> +allOf:
>> >> + - $ref: panel-common.yaml#
>> >> +
>> >> +properties:
>> >> + compatible:
>> >> + const: abt,y030xx067a
>> >> +
>> >> + backlight: true
>> >> + port: true
>> >> + power-supply: true
>> >> + reg: true
>> >> + reset-gpios: true
>> >
>> > The binding is missing:
>> > required:
>> > - compatible
>> > - reg
>> > - power-supply
>> > - reset-gpios
>> > - ...
>> >
>> > additionalProperties: false
>> >
>> > So r-b only with these added.
>>
>> Stupid mistake, sorry about that.
>>
>> I'll V2.
>
> I don't have any V2 in my inbox, but looks like it is in linux-next
> now:
Yes, Sam told me on IRC I could fix it while applying and avoid the V2.
> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.example.dt.yaml:
> panel@0: 'spi-max-frequency' does not match any of the regexes:
> 'pinctrl-[0-9]+'
> From schema:
> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
"make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml"
doesn't complain here :(
-Paul
next prev parent reply other threads:[~2020-11-30 19:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 9:31 [PATCH 0/3] drm/panel: ABT Y030XX067A panel support Paul Cercueil
2020-11-01 9:31 ` [PATCH 1/4] dt-bindings: vendor-prefixes: Add abt vendor prefix Paul Cercueil
2020-11-04 22:32 ` Rob Herring
2020-11-01 9:31 ` [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings Paul Cercueil
2020-11-01 12:29 ` Sam Ravnborg
2020-11-02 10:19 ` Paul Cercueil
2020-11-30 14:32 ` Rob Herring
2020-11-30 19:39 ` Paul Cercueil [this message]
2020-11-30 20:18 ` Rob Herring
2020-11-30 21:48 ` Paul Cercueil
2020-12-05 19:55 ` Sam Ravnborg
2020-11-01 9:31 ` [PATCH 3/4] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8_DELTA media bus format Paul Cercueil
2020-11-01 9:31 ` [PATCH 4/4] drm/panel: Add ABT Y030XX067A 3.0" 320x480 panel Paul Cercueil
2020-11-01 12:26 ` [PATCH 0/3] drm/panel: ABT Y030XX067A panel support Sam Ravnborg
2020-12-17 0:59 ` [PATCH] dt-bindings/display: abt,y030xx067a: Fix binding Paul Cercueil
2020-12-17 6:03 ` Sam Ravnborg
2020-12-18 21:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1XJMKQ.YER47WG3D7R41@crapouillou.net \
--to=paul@crapouillou.net \
--cc=cbranchereau@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).