From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752190AbeENTUk (ORCPT ); Mon, 14 May 2018 15:20:40 -0400 Received: from www62.your-server.de ([213.133.104.62]:43844 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbeENTUi (ORCPT ); Mon, 14 May 2018 15:20:38 -0400 Subject: Re: [PATCH v3] selftests: add headers_install to lib.mk To: Anders Roxell , yamada.masahiro@socionext.com, michal.lkml@markovi.net, shuah@kernel.org, bamv2005@gmail.com, brgl@bgdev.pl, pbonzini@redhat.com, akpm@linux-foundation.org, rppt@linux.vnet.ibm.com, aarcange@redhat.com Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, alexei.starovoitov@gmail.com References: <20180413090351.25662-1-anders.roxell@linaro.org> <20180514115809.9803-1-anders.roxell@linaro.org> From: Daniel Borkmann Message-ID: <1a021bf3-cf93-aa12-c5a8-1ea6c7900fbb@iogearbox.net> Date: Mon, 14 May 2018 21:20:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180514115809.9803-1-anders.roxell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/14/2018 01:58 PM, Anders Roxell wrote: > If the kernel headers aren't installed we can't build all the tests. > Add a new make target rule 'khdr' in the file lib.mk to generate the > kernel headers and that gets include for every test-dir Makefile that > includes lib.mk If the testdir in turn have its own sub-dirs the > top_srcdir needs to be set to the linux-rootdir to be able to generate > the kernel headers. > > Signed-off-by: Anders Roxell > Reviewed-by: Fathi Boudra > --- > Makefile | 14 +------------- > scripts/subarch.include | 13 +++++++++++++ > tools/testing/selftests/android/Makefile | 2 +- > tools/testing/selftests/android/ion/Makefile | 1 + > tools/testing/selftests/bpf/Makefile | 5 ++--- > tools/testing/selftests/futex/functional/Makefile | 1 + > tools/testing/selftests/gpio/Makefile | 7 ++----- > tools/testing/selftests/kvm/Makefile | 7 ++----- > tools/testing/selftests/lib.mk | 10 ++++++++++ > tools/testing/selftests/vm/Makefile | 4 ---- > 10 files changed, 33 insertions(+), 31 deletions(-) > create mode 100644 scripts/subarch.include [...] > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index 438d4f93875b..9741609a0eb1 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -16,9 +16,8 @@ LDLIBS += -lcap -lelf -lrt -lpthread > TEST_CUSTOM_PROGS = $(OUTPUT)/urandom_read > all: $(TEST_CUSTOM_PROGS) > > -$(TEST_CUSTOM_PROGS): urandom_read > - > -urandom_read: urandom_read.c > +$(TEST_CUSTOM_PROGS):| khdr > +$(TEST_CUSTOM_PROGS): urandom_read.c > $(CC) -o $(TEST_CUSTOM_PROGS) -static $< > > # Order correspond to 'make run_tests' order Can you elaborate on the error in BPF you're seeing that would force a headers_install for it? Some people are running the tools/ infrastructure (incl. BPF kselftests) outside of kernel tree where this dependency would break their setup. Why BPF bits cannot be fixed otherwise? Thanks, Daniel