From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DB75CCA489 for ; Fri, 22 Jul 2022 18:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234614AbiGVSh7 (ORCPT ); Fri, 22 Jul 2022 14:37:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232071AbiGVSh4 (ORCPT ); Fri, 22 Jul 2022 14:37:56 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1E3FA026C for ; Fri, 22 Jul 2022 11:37:54 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id z25so9016432lfr.2 for ; Fri, 22 Jul 2022 11:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=pZNADembFWMrMyIeeoU2sLzijZgUqqEN6vVBxD7cEAs=; b=GsqhyOyvPqQLTvBum+zuJxJdCWumdKt28rH2mPmYbBK74XD17jt60KtD0pMHpo/hya vb9wzTzbNdeHuA/5g/kHobFtb0+H7CYDfb4AvZumRqW3JnejJKFeINvR34dlTLchYXjz j0UREVOivqXUfB4/IgLh/3GwMH3nmWpkN29OsnadwZiyJhvuC8Ke+A7q5rONII1LLIRN ur9/WC2nNosjE3LvdRSxF0kGBq3CGOT6wxtYRhP1t3tA3RPVu4/9VS+clhFLMjMPW09o 1TD97bVIN/s+O48yV/5C3XwcnVszKfIepyHe6JQqce4HYChtqdx1Ean31k2MwSuBhPl2 mZzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pZNADembFWMrMyIeeoU2sLzijZgUqqEN6vVBxD7cEAs=; b=5yInyY4RxTOUqDgNBQv5nUoPXvvjCG8XhZ209lNPHibR8mnoXJXK86bV55I1LaKwou fCHjEZOXLAt+3iYUzBVLZt7LIcMVOEm6CSLyGshV3KIHYoUitzBJ0gkRJiAHHxA9nvP1 vsrjsr4W+AT4a7Zzr4WoUKmk2C1VcKjpYxDdq2SENo8g1QVXri6U+NfVTnviNBqlvhbq VYBeOEh7gPvf4pWKh1hvH/0pGnkPwCVVYxJYDo6lIp2iyVx2BWYXvgd384EMFWzp3OJh 4f1J/bbxOR/oHsj2IxzRLO5Rb0LBGwxnkAx/TVGe2utyxTN80Q4orj6cZ8Rx3EKOFmoU AxJg== X-Gm-Message-State: AJIora/qRg8uwAQbaFC8qRYuxk6tX9ua0ZRxxot5uwo9rtSkF2n8LsK4 oUD2lH9yyLR/GzTu0ePHI+QNhA== X-Google-Smtp-Source: AGRyM1t4tkeV7OyDpZcsS6qCtak/AfOICQG9L4dyANvy9yS4TYY7Ac7Z+0mbnuyWn6CiHaHsFou02A== X-Received: by 2002:a05:6512:2622:b0:481:5b17:58e7 with SMTP id bt34-20020a056512262200b004815b1758e7mr478609lfb.600.1658515073264; Fri, 22 Jul 2022 11:37:53 -0700 (PDT) Received: from [192.168.10.173] (93.81-167-86.customer.lyse.net. [81.167.86.93]) by smtp.gmail.com with ESMTPSA id d15-20020a0565123d0f00b0048a7222eb8bsm1008194lfv.135.2022.07.22.11.37.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 11:37:52 -0700 (PDT) Message-ID: <1a03d894-3f4c-fb57-5f05-ad7bf11f5488@linaro.org> Date: Fri, 22 Jul 2022 20:37:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/6] dt-bindings: panel: explicitly list SPI CPHA and CPOL Content-Language: en-US To: Rob Herring Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Linus Walleij , Markuss Broks , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Alexandru Tachici , Marcelo Schmitt , Tomislav Denis , Cosmin Tanislav , Nishant Malpani , Dragos Bogdan , Nuno Sa , Jean-Baptiste Maneyrol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mark Brown , Tomi Valkeinen , Andrzej Hajda , Maxime Ripard , Marek Belisko , "H. Nikolaus Schaller" , Christian Eggers , Beniamin Bia , Stefan Popa , Oskar Andero , =?UTF-8?Q?M=c3=a5rten_Lindahl?= , Dan Murphy , Sean Nyekjaer , Cristian Pop , Lukas Wunner , Matt Ranostay , Matheus Tavares , Sankar Velliangiri , Lubomir Rintel , Stefan Wahren , Pratyush Yadav , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org, netdev@vger.kernel.org, linux-spi@vger.kernel.org References: <20220721153155.245336-1-krzysztof.kozlowski@linaro.org> <20220721153155.245336-2-krzysztof.kozlowski@linaro.org> <20220721193004.GA1783390-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220721193004.GA1783390-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/07/2022 21:30, Rob Herring wrote: > On Thu, Jul 21, 2022 at 05:31:50PM +0200, Krzysztof Kozlowski wrote: >> The spi-cpha and spi-cpol properties are device specific and should be >> accepted only if device really needs them. Explicitly list them in >> device bindings in preparation of their removal from generic >> spi-peripheral-props.yaml schema. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../bindings/display/panel/lgphilips,lb035q02.yaml | 10 ++++++++++ >> .../bindings/display/panel/samsung,ld9040.yaml | 10 ++++++++++ >> .../bindings/display/panel/samsung,lms380kf01.yaml | 12 +++++++++--- >> .../bindings/display/panel/samsung,lms397kf04.yaml | 12 +++++++++--- >> .../bindings/display/panel/samsung,s6d27a1.yaml | 12 +++++++++--- >> .../bindings/display/panel/sitronix,st7789v.yaml | 10 ++++++++++ >> .../devicetree/bindings/display/panel/tpo,td.yaml | 10 ++++++++++ >> 7 files changed, 67 insertions(+), 9 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml >> index 5e4e0e552c2f..0bd7bbad5b94 100644 >> --- a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml >> +++ b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml >> @@ -21,6 +21,16 @@ properties: >> enable-gpios: true >> port: true >> >> + spi-cpha: >> + type: boolean >> + description: >> + The device requires shifted clock phase (CPHA) mode. >> + >> + spi-cpol: >> + type: boolean >> + description: >> + The device requires inverse clock polarity (CPOL) mode. > > Not great duplicating the type and description everywhere. > > We can move the definition back to spi-controller.yaml, so then that > does type checking of the property, but not presence/absence checks. If I understand correctly, all client devices (which do no reference spi-controller) will need to explicitly mention CPHA/CPOL. Good idea. Best regards, Krzysztof